issue_comments

Table actions

14 rows where issue = 1039833986 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Update minimum dependencies for 0.20 · 14 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
956578460 https://github.com/pydata/xarray/pull/5917#issuecomment-956578460 https://api.github.com/repos/pydata/xarray/issues/5917 IC_kwDOAMm_X845BDqc dcherian 2448579 2021-11-01T20:49:30Z 2021-11-01T20:49:30Z MEMBER

Sounds good to me! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum dependencies for 0.20 1039833986
956543887 https://github.com/pydata/xarray/pull/5917#issuecomment-956543887 https://api.github.com/repos/pydata/xarray/issues/5917 IC_kwDOAMm_X845A7OP TomNicholas 35968931 2021-11-01T19:59:27Z 2021-11-01T19:59:27Z MEMBER

It passed! Well done @dcherian ! Can we merge this then? And then release??

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum dependencies for 0.20 1039833986
954981048 https://github.com/pydata/xarray/pull/5917#issuecomment-954981048 https://api.github.com/repos/pydata/xarray/issues/5917 IC_kwDOAMm_X84469q4 github-actions[bot] 41898282 2021-10-29T19:04:25Z 2021-11-01T19:38:20Z CONTRIBUTOR

Unit Test Results

6 files           6 suites   53m 8s :stopwatch: 16 290 tests 14 551 :heavy_check_mark: 1 739 :zzz: 0 :x: 90 936 runs  82 738 :heavy_check_mark: 8 198 :zzz: 0 :x:

Results for commit 8418fccd.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum dependencies for 0.20 1039833986
956524489 https://github.com/pydata/xarray/pull/5917#issuecomment-956524489 https://api.github.com/repos/pydata/xarray/issues/5917 IC_kwDOAMm_X845A2fJ keewis 14808389 2021-11-01T19:28:42Z 2021-11-01T19:28:42Z MEMBER

the download speed for that specific CI job is really slow

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum dependencies for 0.20 1039833986
956520398 https://github.com/pydata/xarray/pull/5917#issuecomment-956520398 https://api.github.com/repos/pydata/xarray/issues/5917 IC_kwDOAMm_X845A1fO TomNicholas 35968931 2021-11-01T19:22:36Z 2021-11-01T19:22:36Z MEMBER

I'm like staring at this one yellow dot crossing my fingers for you @dcherian lol

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   Update minimum dependencies for 0.20 1039833986
956420163 https://github.com/pydata/xarray/pull/5917#issuecomment-956420163 https://api.github.com/repos/pydata/xarray/issues/5917 IC_kwDOAMm_X845AdBD pep8speaks 24736507 2021-11-01T17:12:31Z 2021-11-01T18:49:26Z NONE

Hello @TomNicholas! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1:1: F401 'distutils.version.LooseVersion' imported but unused

Comment last updated at 2021-11-01 18:49:26 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum dependencies for 0.20 1039833986
956451576 https://github.com/pydata/xarray/pull/5917#issuecomment-956451576 https://api.github.com/repos/pydata/xarray/issues/5917 IC_kwDOAMm_X845Akr4 keewis 14808389 2021-11-01T17:54:46Z 2021-11-01T17:54:46Z MEMBER

just for reference, apparently cartopy=0.18 conflicts with pynio (which we were planning to move to a separate repository), and h5py=2.10 seems to be incompatible with hdf5=1.12 (there is a stalled PR on the feedstock)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum dependencies for 0.20 1039833986
956425315 https://github.com/pydata/xarray/pull/5917#issuecomment-956425315 https://api.github.com/repos/pydata/xarray/issues/5917 IC_kwDOAMm_X845AeRj Illviljan 14371165 2021-11-01T17:18:46Z 2021-11-01T17:19:14Z MEMBER

Maybe if you increase scipy to 1.5.2 it would work?

``` (xarray-tests) C:\Users\J.W>conda search conda-forge::scipy=1.5 Loading channels: done

Name Version Build Channel

scipy 1.5.2 py36h7ff6e69_2 conda-forge scipy 1.5.2 py37h6db1a17_2 conda-forge scipy 1.5.2 py38h5f893b4_2 conda-forge scipy 1.5.2 py39hc0c34ad_2 conda-forge scipy 1.5.3 py36h27d303f_1 conda-forge scipy 1.5.3 py36h7ff6e69_0 conda-forge scipy 1.5.3 py37h6db1a17_0 conda-forge scipy 1.5.3 py38h5f893b4_0 conda-forge scipy 1.5.3 py39hc0c34ad_0 conda-forge

```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum dependencies for 0.20 1039833986
956420571 https://github.com/pydata/xarray/pull/5917#issuecomment-956420571 https://api.github.com/repos/pydata/xarray/issues/5917 IC_kwDOAMm_X845AdHb dcherian 2448579 2021-11-01T17:13:01Z 2021-11-01T17:13:01Z MEMBER

i got the env working but not sure if tests pass

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum dependencies for 0.20 1039833986
956407666 https://github.com/pydata/xarray/pull/5917#issuecomment-956407666 https://api.github.com/repos/pydata/xarray/issues/5917 IC_kwDOAMm_X845AZ9y Illviljan 14371165 2021-11-01T16:59:23Z 2021-11-01T16:59:23Z MEMBER

@TomNicholas Try removing setuptools in py37-min-all-deps.yml.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum dependencies for 0.20 1039833986
956405185 https://github.com/pydata/xarray/pull/5917#issuecomment-956405185 https://api.github.com/repos/pydata/xarray/issues/5917 IC_kwDOAMm_X845AZXB TomNicholas 35968931 2021-11-01T16:56:10Z 2021-11-01T16:56:10Z MEMBER

``` Run mamba env update -f $CONDA_ENV_FILE conda-forge/linux-64 Using cache conda-forge/noarch Using cache

Looking for: ['python=3.7', 'boto3=1.13', 'bottleneck=1.3', 'cartopy=0.18', 'cdms2=3.1', 'cfgrib=0.9', 'cftime=1.2', 'coveralls', 'dask=2.30', 'distributed=2.30', 'h5netcdf=0.8', 'h5py=2.10', 'hdf5=1.12', 'hypothesis', 'iris=2.4', 'lxml=4.6', 'matplotlib-base=3.3', 'nc-time-axis=1.2', 'netcdf4=1.5.3', 'numba=0.51', 'numpy=1.18', 'pandas=1.1', 'pint=0.16', 'pip', 'pseudonetcdf=3.1', 'pydap=3.2', 'pynio=1.5', 'pytest', 'pytest-cov', 'pytest-env', 'pytest-xdist', 'rasterio=1.1', 'scipy=1.5', 'seaborn=0.11', 'setuptools', 'sparse=0.11', 'toolz=0.11', 'typing_extensions=3.7', 'zarr=2.5']

Encountered problems while solving: - package scipy-1.5.0-py36h2d22cac_0 requires python_abi 3.6. _cp36m, but none of the providers can be installed - package cartopy-0.18.0-py36h91e5944_2 requires python_abi 3.6. _cp36m, but none of the providers can be installed

Error: Process completed with exit code 1. ```

What is python_abi 3.6.* *_cp36m?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum dependencies for 0.20 1039833986
956183706 https://github.com/pydata/xarray/pull/5917#issuecomment-956183706 https://api.github.com/repos/pydata/xarray/issues/5917 IC_kwDOAMm_X844_jSa keewis 14808389 2021-11-01T12:15:08Z 2021-11-01T12:15:08Z MEMBER

Might be setuptools

if that's the case this should be fixed by merging #5845 first

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum dependencies for 0.20 1039833986
955084481 https://github.com/pydata/xarray/pull/5917#issuecomment-955084481 https://api.github.com/repos/pydata/xarray/issues/5917 IC_kwDOAMm_X8447W7B Illviljan 14371165 2021-10-29T22:35:27Z 2021-10-29T22:35:27Z MEMBER

Might be setuptools, I had similar errors in #5892.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum dependencies for 0.20 1039833986
954969091 https://github.com/pydata/xarray/pull/5917#issuecomment-954969091 https://api.github.com/repos/pydata/xarray/issues/5917 IC_kwDOAMm_X84466wD TomNicholas 35968931 2021-10-29T18:44:12Z 2021-10-29T18:44:12Z MEMBER

Oh right I guess I can't just naively update the conda environment like that, because it might not be a valid solve?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum dependencies for 0.20 1039833986

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);