issue_comments

Table actions

4 rows where issue = 1038531231 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Avoid accessing slow .data in unstack · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
954824888 https://github.com/pydata/xarray/pull/5906#issuecomment-954824888 https://api.github.com/repos/pydata/xarray/issues/5906 IC_kwDOAMm_X8446Xi4 dcherian 2448579 2021-10-29T15:14:35Z 2021-10-29T15:14:35Z MEMBER

Thanks @TomAugspurger 

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Avoid accessing slow .data in unstack 1038531231
954277596 https://github.com/pydata/xarray/pull/5906#issuecomment-954277596 https://api.github.com/repos/pydata/xarray/issues/5906 IC_kwDOAMm_X8444R7c dcherian 2448579 2021-10-28T22:40:30Z 2021-10-28T22:40:30Z MEMBER

Nice work! Our benchmarks show 2X speedup

 
{
    "total_count": 3,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 3,
    "eyes": 0
}
   Avoid accessing slow .data in unstack 1038531231
953856787 https://github.com/pydata/xarray/pull/5906#issuecomment-953856787 https://api.github.com/repos/pydata/xarray/issues/5906 IC_kwDOAMm_X8442rMT github-actions[bot] 41898282 2021-10-28T13:41:19Z 2021-10-28T20:46:49Z CONTRIBUTOR

Unit Test Results

6 files           6 suites   56m 25s :stopwatch: 16 278 tests 14 550 :heavy_check_mark: 1 728 :zzz: 0 :x: 90 864 runs  82 692 :heavy_check_mark: 8 172 :zzz: 0 :x:

Results for commit 6363a761.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Avoid accessing slow .data in unstack 1038531231
953858365 https://github.com/pydata/xarray/pull/5906#issuecomment-953858365 https://api.github.com/repos/pydata/xarray/issues/5906 IC_kwDOAMm_X8442rk9 TomAugspurger 1312546 2021-10-28T13:43:04Z 2021-10-28T13:43:04Z MEMBER

There are two changes here

  1. Only check the .data of non-index variables, done at https://github.com/pydata/xarray/pull/5906/files#diff-763e3002fd954d544b05858d8d138b828b66b6a2a0ae3cd58d2040a652f14638R4161-R4163
  2. The check for whether or not a full index was needed is done in a for dim in dims loop, but the condition doesn't actually depend on dim. So I lifted that check out of the for loop (doesn't matter much, since stuff is cached).

cc @dcherian

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Avoid accessing slow .data in unstack 1038531231

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);