issue_comments

Table actions

6 rows where issue = 1038376514 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Explicitly list all reductions in api.rst · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
953737682 https://github.com/pydata/xarray/pull/5903#issuecomment-953737682 https://api.github.com/repos/pydata/xarray/issues/5903 IC_kwDOAMm_X8442OHS github-actions[bot] 41898282 2021-10-28T11:01:16Z 2021-11-03T15:05:34Z CONTRIBUTOR

Unit Test Results

0 files  0 suites   0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 60bdd0f4.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicitly list all reductions in api.rst 1038376514
958167951 https://github.com/pydata/xarray/pull/5903#issuecomment-958167951 https://api.github.com/repos/pydata/xarray/issues/5903 IC_kwDOAMm_X845HHuP andersy005 13301940 2021-11-02T21:08:46Z 2021-11-02T21:08:46Z MEMBER

This behavior doesn't feel intuitive to me. It does happen on the stable version as well so it isn't related to this PR. Tested on windows 10 and Firefox.

I'll look into this... It appears to be a CSS issue

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicitly list all reductions in api.rst 1038376514
958165165 https://github.com/pydata/xarray/pull/5903#issuecomment-958165165 https://api.github.com/repos/pydata/xarray/issues/5903 IC_kwDOAMm_X845HHCt keewis 14808389 2021-11-02T21:04:28Z 2021-11-02T21:04:28Z MEMBER

I think we should add the commit to both main and stable by cherry-picking to the other branch. A commit that is only on stable can be accidentally dropped on a new release.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicitly list all reductions in api.rst 1038376514
958154062 https://github.com/pydata/xarray/pull/5903#issuecomment-958154062 https://api.github.com/repos/pydata/xarray/issues/5903 IC_kwDOAMm_X845HEVO dcherian 2448579 2021-11-02T20:47:41Z 2021-11-02T20:47:41Z MEMBER

@pydata/xarray I'd like to merge this to stable since it is doc-only and a pretty nice improvement

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicitly list all reductions in api.rst 1038376514
957981056 https://github.com/pydata/xarray/pull/5903#issuecomment-957981056 https://api.github.com/repos/pydata/xarray/issues/5903 IC_kwDOAMm_X845GaGA dcherian 2448579 2021-11-02T17:41:31Z 2021-11-02T17:41:31Z MEMBER

Yeah I noticed that too on Firefox and Chrome (ubuntu)

cc @andersy005 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicitly list all reductions in api.rst 1038376514
957968217 https://github.com/pydata/xarray/pull/5903#issuecomment-957968217 https://api.github.com/repos/pydata/xarray/issues/5903 IC_kwDOAMm_X845GW9Z Illviljan 14371165 2021-11-02T17:25:22Z 2021-11-02T17:25:22Z MEMBER

This looks great!

The only thing I noticed is that when I click on the headers in the content table to the right, the above header is exploded: This behavior doesn't feel intuitive to me. It does happen on the stable version as well so it isn't related to this PR. Tested on windows 10 and Firefox.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicitly list all reductions in api.rst 1038376514

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);