issue_comments

Table actions

5 rows where issue = 1034329171 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • keewis · 5 ✖

issue 1

  • Drop support for python 3.7 · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1010357457 https://github.com/pydata/xarray/pull/5892#issuecomment-1010357457 https://api.github.com/repos/pydata/xarray/issues/5892 IC_kwDOAMm_X848ONTR keewis 14808389 2022-01-11T21:03:57Z 2022-01-11T21:03:57Z MEMBER

should we merge this now and sort the typing out in a new PR?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for python 3.7 1034329171
1006602012 https://github.com/pydata/xarray/pull/5892#issuecomment-1006602012 https://api.github.com/repos/pydata/xarray/issues/5892 IC_kwDOAMm_X847_4cc keewis 14808389 2022-01-06T13:43:15Z 2022-01-06T13:43:15Z MEMBER

that's fine with me, but that would be a new (hard) dependency for python>=3.8 so I think we should make that a new PR

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for python 3.7 1034329171
1006124582 https://github.com/pydata/xarray/pull/5892#issuecomment-1006124582 https://api.github.com/repos/pydata/xarray/issues/5892 IC_kwDOAMm_X847-D4m keewis 14808389 2022-01-05T22:21:40Z 2022-01-05T22:39:20Z MEMBER

I feel having to do these kinds of workarounds is not nice and sucks out any willpower of improving typing

Well, I can understand that: it's usually the same with other actively developed libraries.

My point was actually that the changes I applied shouldn't have changed the dependencies we currently have: typing_extensions was restricted to python < 3.8 before, so it was only installed on python=3.7 (unless it was installed using conda / from conda-forge, which doesn't support this kind of restriction).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for python 3.7 1034329171
1006063883 https://github.com/pydata/xarray/pull/5892#issuecomment-1006063883 https://api.github.com/repos/pydata/xarray/issues/5892 IC_kwDOAMm_X84791EL keewis 14808389 2022-01-05T20:44:58Z 2022-01-05T20:44:58Z MEMBER

we're already using TypeGuard in xarray.core.utils, so I guess it has to stay as a optional dependency (i.e. I will add it back to py38-min-all-deps). I don't think we still need the hard dependency, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for python 3.7 1034329171
1005998870 https://github.com/pydata/xarray/pull/5892#issuecomment-1005998870 https://api.github.com/repos/pydata/xarray/issues/5892 IC_kwDOAMm_X8479lMW keewis 14808389 2022-01-05T19:04:35Z 2022-01-05T19:52:57Z MEMBER

what do we do about the typing_extensions and importlib-resources dependencies? Those are py37-only at the moment... I guess we don't need importlib-resources anymore, but what about typing_extensions? Is it a optional dependency?

Also, there's a mention of python=3.7 in dask_array_ops related to the method parameter of cumreduction. What is that about?

Edit: otherwise, this looks good to me

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for python 3.7 1034329171

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);