issue_comments

Table actions

13 rows where issue = 1034238626 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Release v0.20? · 13 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
957991489 https://github.com/pydata/xarray/issues/5889#issuecomment-957991489 https://api.github.com/repos/pydata/xarray/issues/5889 IC_kwDOAMm_X845GcpB TomNicholas 35968931 2021-11-02T17:55:19Z 2021-11-02T18:38:49Z MEMBER

Oh I see it now too.

Are we done then? Is v0.20.0 supposed to appear in the dropdown menu in the lower-right of the main docs page?

EDIT: I see it now. Consider this release done!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.20? 1034238626
957983787 https://github.com/pydata/xarray/issues/5889#issuecomment-957983787 https://api.github.com/repos/pydata/xarray/issues/5889 IC_kwDOAMm_X845Gawr dcherian 2448579 2021-11-02T17:45:03Z 2021-11-02T17:45:03Z MEMBER

I see it. Activating...

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.20? 1034238626
957981050 https://github.com/pydata/xarray/issues/5889#issuecomment-957981050 https://api.github.com/repos/pydata/xarray/issues/5889 IC_kwDOAMm_X845GaF6 TomNicholas 35968931 2021-11-02T17:41:30Z 2021-11-02T17:41:30Z MEMBER

Update the docs. Login to https://readthedocs.org/projects/xray/versions/ and switch your new release tag (at the bottom) from "Inactive" to "Active". It should now build automatically.

I did all the other steps, but I don't see the v0.20.0 release tag on readthedocs :confused:

I cancelled a workflow that I thought was superfluous - was it actually needed?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.20? 1034238626
956786322 https://github.com/pydata/xarray/issues/5889#issuecomment-956786322 https://api.github.com/repos/pydata/xarray/issues/5889 IC_kwDOAMm_X845B2aS keewis 14808389 2021-11-01T22:42:27Z 2021-11-01T22:42:42Z MEMBER

do we know where the failures in #5919 are coming from? It would probably be good to fix them before the release...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.20? 1034238626
954921707 https://github.com/pydata/xarray/issues/5889#issuecomment-954921707 https://api.github.com/repos/pydata/xarray/issues/5889 IC_kwDOAMm_X8446vLr keewis 14808389 2021-10-29T17:35:42Z 2021-10-29T17:36:08Z MEMBER

What does this involve?

Updating the two min deps conda environment files and listing the changes in whats-new.rst is usually enough, but for numpy and pandas we need to update setup.cfg. There might be also some compatibility code that can be removed, and documentation pages that need to be updated, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.20? 1034238626
954916661 https://github.com/pydata/xarray/issues/5889#issuecomment-954916661 https://api.github.com/repos/pydata/xarray/issues/5889 IC_kwDOAMm_X8446t81 TomNicholas 35968931 2021-10-29T17:27:02Z 2021-10-29T17:27:02Z MEMBER

It looks like we can bump minimum versions on a bunch of packages if someone is up for doing it:

What does this involve?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.20? 1034238626
954904111 https://github.com/pydata/xarray/issues/5889#issuecomment-954904111 https://api.github.com/repos/pydata/xarray/issues/5889 IC_kwDOAMm_X8446q4v dcherian 2448579 2021-10-29T17:05:58Z 2021-10-29T17:05:58Z MEMBER

It looks like we can bump minimum versions on a bunch of packages if someone is up for doing it:

``` Package Required Policy Status

cartopy 0.17 (2018-11-17) 0.18 (2020-07-09) < cftime 1.1 (2020-03-15) 1.2 (2020-07-05) < dask 2.24 (2020-08-24) 2.30 (2020-10-07) < distributed 2.24 (2020-08-22) 2.30 (2020-10-07) < hdf5 1.10 (2017-09-18) 1.12 (2020-08-03) < lxml 4.5 (2020-01-29) 4.6 (2020-10-17) < matplotlib-base 3.2 (2020-03-04) 3.3 (2020-07-20) < numba 0.49 (2020-04-17) 0.51 (2020-08-17) < numpy 1.17 (2019-08-01) 1.18 (2020-01-16) < pandas 1.0 (2020-01-29) 1.1 (2020-07-28) < pint 0.15 (2020-08-22) 0.16 (2020-09-14) < scipy 1.4 (2019-12-19) 1.5 (2020-06-23) < seaborn 0.10 (2020-01-31) 0.11 (2020-09-08) < sparse 0.8 (2019-08-26) 0.11 (2020-08-18) < toolz 0.10 (2019-07-12) 0.11 (2020-09-24) < zarr 2.4 (2020-01-11) 2.5 (2020-10-08) < ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.20? 1034238626
954832155 https://github.com/pydata/xarray/issues/5889#issuecomment-954832155 https://api.github.com/repos/pydata/xarray/issues/5889 IC_kwDOAMm_X8446ZUb dcherian 2448579 2021-10-29T15:24:43Z 2021-10-29T15:24:43Z MEMBER

It'd be nice to get #5911 in since that adds a new dependency and this is a major version

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.20? 1034238626
954017277 https://github.com/pydata/xarray/issues/5889#issuecomment-954017277 https://api.github.com/repos/pydata/xarray/issues/5889 IC_kwDOAMm_X8443SX9 TomNicholas 35968931 2021-10-28T16:41:27Z 2021-10-28T16:41:35Z MEMBER

@keewis there is a note in whats-new.rst:

.. TODO(by keewis): update deprecations if we decide to skip 0.19.1

We are going to be skipping 0.19.1 because we have breaking changes, so I'm just flagging that so it doesn't get forgotten.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.20? 1034238626
950801676 https://github.com/pydata/xarray/issues/5889#issuecomment-950801676 https://api.github.com/repos/pydata/xarray/issues/5889 IC_kwDOAMm_X844rBUM mathause 10194086 2021-10-25T11:02:38Z 2021-10-25T11:02:38Z MEMBER

Could also be good to fix #5721 before the release. @benbovy are you still up for this?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.20? 1034238626
950738664 https://github.com/pydata/xarray/issues/5889#issuecomment-950738664 https://api.github.com/repos/pydata/xarray/issues/5889 IC_kwDOAMm_X844qx7o benbovy 4160723 2021-10-25T09:51:57Z 2021-10-25T09:51:57Z MEMBER

We should definitely make a release before #5692 gets merged. I've made good progress, but it's not ready yet. It'll also be safer to have one last stable release before merging all those changes. Once it is merged, we'll probably need a few release candidates and beta testers to ensure that we don't break important use cases that CI didn't caught.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.20? 1034238626
950392205 https://github.com/pydata/xarray/issues/5889#issuecomment-950392205 https://api.github.com/repos/pydata/xarray/issues/5889 IC_kwDOAMm_X844pdWN spencerkclark 6628425 2021-10-24T20:45:36Z 2021-10-24T20:45:36Z MEMBER

It would be cool if we could merge #5233 before the next release as well. I think it is ready, and @aulemahal has been diligently working on it for the last several months (and been very patient with my sporadic reviewing frequency).

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.20? 1034238626
950208675 https://github.com/pydata/xarray/issues/5889#issuecomment-950208675 https://api.github.com/repos/pydata/xarray/issues/5889 IC_kwDOAMm_X844owij max-sixty 5635139 2021-10-23T20:28:06Z 2021-10-23T20:28:06Z MEMBER

I have been out of the loop for ages — thanks for others pulling up my slack — but I could help with this

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.20? 1034238626

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);