issue_comments

Table actions

7 rows where issue = 1028110240 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • max-sixty · 7 ✖

issue 1

  • Generator for groupby reductions · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
962498057 https://github.com/pydata/xarray/pull/5871#issuecomment-962498057 https://api.github.com/repos/pydata/xarray/issues/5871 IC_kwDOAMm_X845Xo4J max-sixty 5635139 2021-11-06T19:21:46Z 2021-11-06T19:21:46Z MEMBER

Big win @dcherian ! Thanks a lot. By LoC, xarray just got 4% better in a single PR!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Generator for groupby reductions 1028110240
951117633 https://github.com/pydata/xarray/pull/5871#issuecomment-951117633 https://api.github.com/repos/pydata/xarray/issues/5871 IC_kwDOAMm_X844sOdB max-sixty 5635139 2021-10-25T16:54:48Z 2021-10-25T16:54:48Z MEMBER

Unless @shoyer has any objections — I think we were primarily delayed by Apache Beam, and they have unlocked that dependency, so I would vote to add it as a required dependency. The only realistic way this could be bad is if there's another package that is commonly installed with xarray that a) requires typing_extensions, b) forbids a recent version, c) won't remove that pin soon.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Generator for groupby reductions 1028110240
950304347 https://github.com/pydata/xarray/pull/5871#issuecomment-950304347 https://api.github.com/repos/pydata/xarray/issues/5871 IC_kwDOAMm_X844pH5b max-sixty 5635139 2021-10-24T11:06:56Z 2021-10-24T11:06:56Z MEMBER

I think @keewis mentioned we could drop 3.7 in December which is not that far away. Can we type self as Any for now and update later?

What are your thoughts re adding the typing_extensions dependency?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Generator for groupby reductions 1028110240
950268614 https://github.com/pydata/xarray/pull/5871#issuecomment-950268614 https://api.github.com/repos/pydata/xarray/issues/5871 IC_kwDOAMm_X844o_LG max-sixty 5635139 2021-10-24T06:26:24Z 2021-10-24T06:26:24Z MEMBER

I just checked Apache beam (the library that prevented us upgrading last time), and they now support typing-extensions<4, so I would vote to add that dependency, rather than drop 3.7.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Generator for groupby reductions 1028110240
950237563 https://github.com/pydata/xarray/pull/5871#issuecomment-950237563 https://api.github.com/repos/pydata/xarray/issues/5871 IC_kwDOAMm_X844o3l7 max-sixty 5635139 2021-10-24T00:27:31Z 2021-10-24T00:27:31Z MEMBER

Bah, Protocol isn't supported in 3.7! We could either revisit mandating typing_extensions or drop 3.7 (which is overdue since our change to only allow 24 months for python releases).

Is it possible to mandate typing_extensions for only 3.7?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Generator for groupby reductions 1028110240
950236575 https://github.com/pydata/xarray/pull/5871#issuecomment-950236575 https://api.github.com/repos/pydata/xarray/issues/5871 IC_kwDOAMm_X844o3Wf max-sixty 5635139 2021-10-24T00:17:15Z 2021-10-24T00:17:15Z MEMBER

I fixed mypy! @Illviljan thanks for the Protocol suggestion. I had to make a different one per class, because the return type for reduce couldn't be generic (I think, unless there's a way...)

Actually much more tedious was fixing black given line-breaks etc.

Great work @dcherian !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Generator for groupby reductions 1028110240
950229311 https://github.com/pydata/xarray/pull/5871#issuecomment-950229311 https://api.github.com/repos/pydata/xarray/issues/5871 IC_kwDOAMm_X844o1k_ max-sixty 5635139 2021-10-23T23:01:18Z 2021-10-23T23:01:18Z MEMBER

I'm having trouble with mypy though. Please help!

I tried for a while. I'm still trying!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Generator for groupby reductions 1028110240

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);