issue_comments

Table actions

8 rows where issue = 1027640127 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Add var and std to weighted computations · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1005179153 https://github.com/pydata/xarray/pull/5870#issuecomment-1005179153 https://api.github.com/repos/pydata/xarray/issues/5870 IC_kwDOAMm_X8476dER cjauvin 488992 2022-01-04T21:20:58Z 2022-01-04T21:20:58Z CONTRIBUTOR

@dgilford I have worked on it: https://github.com/pydata/xarray/pull/6059, but unfortunately the PR is currently stuck in limbo, for technical reasons.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add var and std to weighted computations 1027640127
1005172307 https://github.com/pydata/xarray/pull/5870#issuecomment-1005172307 https://api.github.com/repos/pydata/xarray/issues/5870 IC_kwDOAMm_X8476bZT dgilford 8387331 2022-01-04T21:09:28Z 2022-01-04T21:09:28Z NONE

Is there an appetite to add a weighted quantile method as well ?

I would be strongly interested in this capability!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add var and std to weighted computations 1027640127
953738576 https://github.com/pydata/xarray/pull/5870#issuecomment-953738576 https://api.github.com/repos/pydata/xarray/issues/5870 IC_kwDOAMm_X8442OVQ dcherian 2448579 2021-10-28T11:02:37Z 2021-10-28T11:02:37Z MEMBER

Thanks @cjauvin I see this is your first PR. It's a great one. Welcome to xarray!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add var and std to weighted computations 1027640127
952039300 https://github.com/pydata/xarray/pull/5870#issuecomment-952039300 https://api.github.com/repos/pydata/xarray/issues/5870 IC_kwDOAMm_X844vveE cjauvin 488992 2021-10-26T15:11:30Z 2021-10-26T15:11:30Z CONTRIBUTOR

Thanks for the feedback @mathause! If you are ok with postponing the addition of an extra ddof param for a later PR, as you have suggested, then this PR is indeed complete from my perspective. I will try to propose an implementation for weighted quantiles soon.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add var and std to weighted computations 1027640127
951258747 https://github.com/pydata/xarray/pull/5870#issuecomment-951258747 https://api.github.com/repos/pydata/xarray/issues/5870 IC_kwDOAMm_X844sw57 huard 81219 2021-10-25T19:56:23Z 2021-10-25T19:56:23Z CONTRIBUTOR

Is there an appetite to add a weighted quantile method as well ? 

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add var and std to weighted computations 1027640127
945554219 https://github.com/pydata/xarray/pull/5870#issuecomment-945554219 https://api.github.com/repos/pydata/xarray/issues/5870 IC_kwDOAMm_X844XAMr mathause 10194086 2021-10-18T08:58:32Z 2021-10-18T08:58:32Z MEMBER

Looks good - nice first xarray PR! One thing you could add is "degrees of freedom" for var and std (see statsmodels.stats.weightstats) - but I would also be ok to leave this out until someone requests it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add var and std to weighted computations 1027640127
944515350 https://github.com/pydata/xarray/pull/5870#issuecomment-944515350 https://api.github.com/repos/pydata/xarray/issues/5870 IC_kwDOAMm_X844TCkW github-actions[bot] 41898282 2021-10-15T18:38:40Z 2021-10-16T03:46:56Z CONTRIBUTOR

Unit Test Results

6 files           6 suites   57m 3s :stopwatch: 16 298 tests 14 562 :heavy_check_mark: 1 736 :zzz: 0 :x: 90 984 runs  82 802 :heavy_check_mark: 8 182 :zzz: 0 :x:

Results for commit 4b7d866a.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add var and std to weighted computations 1027640127
944463447 https://github.com/pydata/xarray/pull/5870#issuecomment-944463447 https://api.github.com/repos/pydata/xarray/issues/5870 IC_kwDOAMm_X844S15X pep8speaks 24736507 2021-10-15T17:13:34Z 2021-10-15T20:23:32Z NONE

Hello @cjauvin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-10-15 20:23:32 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add var and std to weighted computations 1027640127

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);