issue_comments

Table actions

2 rows where issue = 1024011835 and user = 35968931 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • TomNicholas · 2 ✖

issue 1

  • Incorrect results when using xarray.ufuncs.angle(..., deg=True) · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1243744713 https://github.com/pydata/xarray/issues/5857#issuecomment-1243744713 https://api.github.com/repos/pydata/xarray/issues/5857 IC_kwDOAMm_X85KIgnJ TomNicholas 35968931 2022-09-12T13:28:35Z 2022-09-12T13:28:35Z MEMBER

np.angle is still not a ufunc

Yes it would be nice if this were fixed upstream. (Would you be interested in having a go?)

What is the recommended workaround here for code that depends on xr.ufuncs.angle?

Perhaps you could make a custom angle function that does behave like a ufunc, maybe like the example given here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Incorrect results when using xarray.ufuncs.angle(..., deg=True) 1024011835
941280214 https://github.com/pydata/xarray/issues/5857#issuecomment-941280214 https://api.github.com/repos/pydata/xarray/issues/5857 IC_kwDOAMm_X844GsvW TomNicholas 35968931 2021-10-12T18:39:19Z 2021-10-12T19:46:53Z MEMBER

The result of numpy.angle(xarray.DataArray) is not a DataArray object, contrary to other numpy operations

This is because np.angle is not a ufunc - the cleanest solution to this should be to fix that issue in numpy.

EDIT: Of course that doesn't explain why xarray.ufuncs.angle is behaving incorrectly - it just means that if we fixed the upstream issue in numpy then no-one need use xarray.ufuncs.angle.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Incorrect results when using xarray.ufuncs.angle(..., deg=True) 1024011835

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);