issue_comments

Table actions

5 rows where issue = 100601294 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • 64-bit values are coerced to 32-bit when writing as NETCDF4_CLASSIC · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
136860559 https://github.com/pydata/xarray/issues/526#issuecomment-136860559 https://api.github.com/repos/pydata/xarray/issues/526 MDEyOklzc3VlQ29tbWVudDEzNjg2MDU1OQ== shoyer 1217238 2015-09-01T21:02:08Z 2015-09-01T21:02:08Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   64-bit values are coerced to 32-bit when writing as NETCDF4_CLASSIC 100601294
130536778 https://github.com/pydata/xarray/issues/526#issuecomment-130536778 https://api.github.com/repos/pydata/xarray/issues/526 MDEyOklzc3VlQ29tbWVudDEzMDUzNjc3OA== petercable 6645714 2015-08-13T05:06:46Z 2015-08-13T05:08:02Z CONTRIBUTOR

I did some more investigating while working on a fix for this issue. It turns out that only the F8 format is supported and this fix is applicable to all NETCDF3-compatible formats.

https://www.unidata.ucar.edu/software/netcdf/docs/netcdf-c/NetCDF_002d3-Variable-Types.html

| Type | C #define | Bits | | --- | --- | --- | | byte | NC_BYTE | 8 | | char | NC_CHAR | 8 | | short | NC_SHORT | 16 | | int | NC_INT | 32 | | float | NC_FLOAT | 32 | | double | NC_DOUBLE | 64 |

I have updated the issue title to reflect this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   64-bit values are coerced to 32-bit when writing as NETCDF4_CLASSIC 100601294
130444086 https://github.com/pydata/xarray/issues/526#issuecomment-130444086 https://api.github.com/repos/pydata/xarray/issues/526 MDEyOklzc3VlQ29tbWVudDEzMDQ0NDA4Ng== shoyer 1217238 2015-08-12T20:50:35Z 2015-08-12T20:50:35Z MEMBER

Yes, we would need a unit test to verify the change. It could be as simple as writing a file to disk as NETCDF4_CLASSIC and verifying that the dtype is preserved when it's read back.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   64-bit values are coerced to 32-bit when writing as NETCDF4_CLASSIC 100601294
130416921 https://github.com/pydata/xarray/issues/526#issuecomment-130416921 https://api.github.com/repos/pydata/xarray/issues/526 MDEyOklzc3VlQ29tbWVudDEzMDQxNjkyMQ== petercable 6645714 2015-08-12T19:19:51Z 2015-08-12T19:19:51Z CONTRIBUTOR

Sure, I'll take a look at it tonight if I get a chance. Do you need corresponding unit tests for any changes? I haven't looked...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   64-bit values are coerced to 32-bit when writing as NETCDF4_CLASSIC 100601294
130398954 https://github.com/pydata/xarray/issues/526#issuecomment-130398954 https://api.github.com/repos/pydata/xarray/issues/526 MDEyOklzc3VlQ29tbWVudDEzMDM5ODk1NA== shoyer 1217238 2015-08-12T18:16:30Z 2015-08-12T18:16:30Z MEMBER

Indeed, it looks like netCDF4_classic can handle 64-bit variables. I misunderstand the description of that file format.

I think your diagnosis about the issue here is correct. Any interest in putting together a fix?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   64-bit values are coerced to 32-bit when writing as NETCDF4_CLASSIC 100601294

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);