home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

11 rows where author_association = "NONE" and user = 88113 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, reactions, created_at (date), updated_at (date)

issue 7

  • Feature Request: Hierarchical storage and processing in xarray 3
  • Should the zarr backend support NCZarr conventions? 3
  • encoding of boolean dtype in zarr 1
  • Awkward array backend? 1
  • Saving zarr to remote location lower cases all data_vars 1
  • Multi-scale datasets and custom indexes 1
  • implement Zarr v3 spec support 1

user 1

  • joshmoore · 11 ✖

author_association 1

  • NONE · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1257908330 https://github.com/pydata/xarray/pull/6475#issuecomment-1257908330 https://api.github.com/repos/pydata/xarray/issues/6475 IC_kwDOAMm_X85K-ihq joshmoore 88113 2022-09-26T11:46:05Z 2022-09-26T11:46:05Z NONE

wait for zarr v2.13 release,

Done. And should be out on conda-forge later today.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  implement Zarr v3 spec support 1200581329
1254775144 https://github.com/pydata/xarray/issues/4285#issuecomment-1254775144 https://api.github.com/repos/pydata/xarray/issues/4285 IC_kwDOAMm_X85Kyllo joshmoore 88113 2022-09-22T09:36:26Z 2022-09-22T09:36:26Z NONE

Definitely interested and interestedly watching 🍿

jpivarski commented on Aug 10 It shouldn't be a subclass because it doesn't satisfy a substitution principle: ak.combinations(array: ak.Array, n: int) -> ak.Array, but ak.combinations(array: RaggedArray, n: int) -> ⊥ (at best, would raise an exception because RaggedArray isn't closed under ak.combinations).

A question from the perspective of Zarr (v3), does it make sense to think of this potential RaggedArray as a base extension that AwkwardArray could then build on top of? (i.e. the reverse) Or more something to keep separate and it's just a matter of the same library could be used to read (de/serialize) either?

More generally, :heart: for all of this, and interested to see how I/we can possibly help.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Awkward array backend? 667864088
1076942019 https://github.com/pydata/xarray/issues/6374#issuecomment-1076942019 https://api.github.com/repos/pydata/xarray/issues/6374 IC_kwDOAMm_X85AMNTD joshmoore 88113 2022-03-24T00:18:14Z 2022-03-24T00:18:14Z NONE

rabernat commented 7 hours ago My opinion is that we should not try to support the nczarr conventions directly. Xarray already supports nczarr via netCDF4. If netCDF4 can open the Zarr store, then Xarray can read it. ... I would turn this question around and ask: if netCDF4 supports access to these datasets directly, what's the advantage of xarray bypassing netCDF4 and opening them directly?

@malmans2 can chime in with his experience, but it seems that from the user point-of-view, not needing to know if something is an xarray-zarr or a nczarr would be kinder of us. Plus as said below, I do think it puts us on the path to defining a common spec.

Supporting nczarr directly would require lots of custom logic within xarray.

Mea culpa. I wasn't clear enough about the intent from my side at least, namely to support loading ARRAY_DIMENSIONS (or some other necessary subset) from nczarr rather than its entirety.

DennisHeimbigner commented 4 hours ago this is because xarray cannot handle subgroups.

I'll add as a side that work on the subgroups (i.e. datatree) is progressing in case any consideration needs to be included now rather than later.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Should the zarr backend support NCZarr conventions? 1172229856
1076601482 https://github.com/pydata/xarray/issues/6374#issuecomment-1076601482 https://api.github.com/repos/pydata/xarray/issues/6374 IC_kwDOAMm_X85AK6KK joshmoore 88113 2022-03-23T17:22:23Z 2022-03-23T17:22:23Z NONE

Thanks, @max-sixty! Guess it just doesn't complete for those outside the org.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Should the zarr backend support NCZarr conventions? 1172229856
1076544302 https://github.com/pydata/xarray/issues/6374#issuecomment-1076544302 https://api.github.com/repos/pydata/xarray/issues/6374 IC_kwDOAMm_X85AKsMu joshmoore 88113 2022-03-23T16:31:53Z 2022-03-23T16:31:53Z NONE

Thanks for the details, @DennisHeimbigner. But my reading of what you outline is that for some nczarr datasets, xarray will be able to open them. Correct? If so, there were always likely to be follow-on's to this issue when/if we identify critical edge cases. Perhaps for the moment, though, we can focus here on what we want to enable and what can be done straight-forwardly.

That likely makes this more a question for @shoyer, @jhamman, @rabernat et al. (sorry, no way to @-mention all the current devs) @malmans2 is probably in a good place to start updating the existing Zarr backend to also check for the nczarr files, but if there are strong opinions against or alternatives that would be preferred, it would be good to hear about them.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Should the zarr backend support NCZarr conventions? 1172229856
860879523 https://github.com/pydata/xarray/issues/5028#issuecomment-860879523 https://api.github.com/repos/pydata/xarray/issues/5028 MDEyOklzc3VlQ29tbWVudDg2MDg3OTUyMw== joshmoore 88113 2021-06-14T17:58:36Z 2021-06-14T17:58:36Z NONE

A heads up that https://github.com/zarr-developers/zarr-python/pull/755 reverses the default behavior of FSStore and so as of Zarr 2.8.3 this might "just work"?

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Saving zarr to remote location lower cases all data_vars 830507003
848914165 https://github.com/pydata/xarray/issues/5376#issuecomment-848914165 https://api.github.com/repos/pydata/xarray/issues/5376 MDEyOklzc3VlQ29tbWVudDg0ODkxNDE2NQ== joshmoore 88113 2021-05-26T16:23:13Z 2021-05-26T16:23:13Z NONE

I don't think I am familiar enough to really judge between the suggestions, @benbovy, but I'm intrigued. I think there's certainly something to be won just by having a data structure which says these arrays/datasets represent a multiscale series. One real benefit though will be when access of that structure can simplify the client code needed to interactively load that data, e.g. with prefetching.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Multi-scale datasets and custom indexes 902009258
833574864 https://github.com/pydata/xarray/issues/4118#issuecomment-833574864 https://api.github.com/repos/pydata/xarray/issues/4118 MDEyOklzc3VlQ29tbWVudDgzMzU3NDg2NA== joshmoore 88113 2021-05-06T14:36:37Z 2021-05-06T14:36:37Z NONE

Picking up on @dcherian's https://github.com/pydata/xarray/issues/4118#issuecomment-806954634 and @rabernat's https://github.com/ome/ngff/issues/48#issuecomment-833456889, Zarr was also accepted to the second round and certainly references this issue in case we want to sync up. (Apologies if I missed where that discussion moved.)

{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 2,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Feature Request: Hierarchical storage and processing in xarray 628719058
806494079 https://github.com/pydata/xarray/issues/4118#issuecomment-806494079 https://api.github.com/repos/pydata/xarray/issues/4118 MDEyOklzc3VlQ29tbWVudDgwNjQ5NDA3OQ== joshmoore 88113 2021-03-25T09:21:47Z 2021-03-25T09:21:47Z NONE

Happy to provide assistance on the image pyramid (i.e. "multiscale") use case.

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Feature Request: Hierarchical storage and processing in xarray 628719058
756204582 https://github.com/pydata/xarray/issues/4118#issuecomment-756204582 https://api.github.com/repos/pydata/xarray/issues/4118 MDEyOklzc3VlQ29tbWVudDc1NjIwNDU4Mg== joshmoore 88113 2021-01-07T15:57:03Z 2021-01-07T15:57:03Z NONE

Thanks for the link, @jhamman. The most immediate issue I ran into when trying to use xarray with OME-Zarr data does seem similar. A rough representation of one multiscale image is:

image_pyramid: |_ zyx_array_high_res |_ zyx_array_mid_res |_ zyx_array_low_res

but of course the x, y and z dimensions are of different sizes in each volume.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Feature Request: Hierarchical storage and processing in xarray 628719058
652358007 https://github.com/pydata/xarray/issues/2937#issuecomment-652358007 https://api.github.com/repos/pydata/xarray/issues/2937 MDEyOklzc3VlQ29tbWVudDY1MjM1ODAwNw== joshmoore 88113 2020-07-01T11:16:40Z 2020-07-01T11:16:40Z NONE

@rabernat : I don't assume you've found a workaround for this?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  encoding of boolean dtype in zarr 439875798

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 16.805ms · About: xarray-datasette