issue_comments

Table actions

7 rows where author_association = "NONE" and user = 6897215 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, reactions, created_at (date), updated_at (date)

user 1

  • basnijholt · 7 ✖

author_association 1

  • NONE · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1483082222 https://github.com/pydata/xarray/pull/7654#issuecomment-1483082222 https://api.github.com/repos/pydata/xarray/issues/7654 IC_kwDOAMm_X85YZgnu basnijholt 6897215 2023-03-24T16:27:01Z 2023-03-24T16:27:01Z NONE

Just leaving a note here. I would expect that the datatype that was saved, is the datatype that is loaded. So preferably if I save a string array of e.g., type <U5, I expect it would still be <U5 when loaded, not suddenly HDF5 VLEN types.

Thanks again @kmuehlbauer for digging into this problem and all your work! 😄 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cf-coding 1633623916
1480030763 https://github.com/pydata/xarray/issues/7652#issuecomment-1480030763 https://api.github.com/repos/pydata/xarray/issues/7652 IC_kwDOAMm_X85YN3or basnijholt 6897215 2023-03-22T18:04:29Z 2023-03-22T18:04:29Z NONE

@kmuehlbauer, great!

I can confirm that both problems are indeed fixed on my end when using h5netcdf and the code from your PR :tada:

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   Saving and loading an array of strings changes datatype to object 1632718954
1478911024 https://github.com/pydata/xarray/issues/7652#issuecomment-1478911024 https://api.github.com/repos/pydata/xarray/issues/7652 IC_kwDOAMm_X85YJmQw basnijholt 6897215 2023-03-22T04:43:46Z 2023-03-22T04:44:17Z NONE

Thanks a lot @kmuehlbauer!

I replied in your PR :smile:

I can confirm that this fixes - https://github.com/pydata/xarray/issues/7652#issuecomment-1476956975 (bool -> int8)

But not int64 -> int32, and <U1 -> O - https://github.com/pydata/xarray/issues/7652#issuecomment-1476967312 - https://github.com/pydata/xarray/issues/7652#issue-1632718954

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Saving and loading an array of strings changes datatype to object 1632718954
1478909815 https://github.com/pydata/xarray/pull/7654#issuecomment-1478909815 https://api.github.com/repos/pydata/xarray/issues/7654 IC_kwDOAMm_X85YJl93 basnijholt 6897215 2023-03-22T04:41:05Z 2023-03-22T04:43:03Z NONE 
{
    "total_count": 2,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 1
}
   cf-coding 1633623916
1476967312 https://github.com/pydata/xarray/issues/7652#issuecomment-1476967312 https://api.github.com/repos/pydata/xarray/issues/7652 IC_kwDOAMm_X85YCLuQ basnijholt 6897215 2023-03-20T21:34:30Z 2023-03-20T21:34:30Z NONE

Another fun one where int64 -> int32: ```python import xarray as xr

da = xr.DataArray(data=[1], dims=["x"], coords={"x": [0]}) da.to_netcdf("test.nc", mode="w") da2 = xr.load_dataarray("test.nc") da.dtype, da2.dtype ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Saving and loading an array of strings changes datatype to object 1632718954
1476956975 https://github.com/pydata/xarray/issues/7652#issuecomment-1476956975 https://api.github.com/repos/pydata/xarray/issues/7652 IC_kwDOAMm_X85YCJMv basnijholt 6897215 2023-03-20T21:25:59Z 2023-03-20T21:34:24Z NONE

A similar problem where saving, loading, saving, loading changes the dtype bool -> int8: ```python import xarray as xr

da1 = xr.DataArray(data=[True], dims=["x"], coords={"x": [0]}) da1.to_netcdf("test.nc", mode="w")

da2 = xr.load_dataarray("test.nc") da2.to_netcdf("test.nc", mode="w")

da3 = xr.load_dataarray("test.nc") assert da1.dtype == da3.dtype, "Dtypes don't match" ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Saving and loading an array of strings changes datatype to object 1632718954
396737241 https://github.com/pydata/xarray/issues/1914#issuecomment-396737241 https://api.github.com/repos/pydata/xarray/issues/1914 MDEyOklzc3VlQ29tbWVudDM5NjczNzI0MQ== basnijholt 6897215 2018-06-12T21:18:18Z 2018-06-12T21:18:18Z NONE

This StackOverflow question is related to this "issue". 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cartesian product of coordinates and using it to index / fill empty dataset 297560256

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);