issue_comments

Table actions

3 rows where author_association = "NONE" and issue = 925533850 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • fix dtype complex for rasterio backend · 3 ✖

author_association 1

  • NONE · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
905555330 https://github.com/pydata/xarray/pull/5501#issuecomment-905555330 https://api.github.com/repos/pydata/xarray/issues/5501 IC_kwDOAMm_X841-a2C agrouaze 14925067 2021-08-25T14:34:07Z 2021-08-25T14:35:27Z NONE

I added a test in test_backends.py : pytest -s ./test_backends.py::TestRasterio::test_rasterio_complex_dtype But since there is a coming fix in rasterio I am wondering whether this PR is still needed: https://github.com/mapbox/rasterio/commit/7114fb7fb5e48146c4f04eb818daaa1fa632d817 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix dtype complex for rasterio backend 925533850
864508390 https://github.com/pydata/xarray/pull/5501#issuecomment-864508390 https://api.github.com/repos/pydata/xarray/issues/5501 MDEyOklzc3VlQ29tbWVudDg2NDUwODM5MA== pep8speaks 24736507 2021-06-20T06:49:57Z 2021-08-25T14:30:57Z NONE

Hello @grouny! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 4171:42: E231 missing whitespace after ',' Line 4705:37: E201 whitespace after '(' Line 4705:42: E202 whitespace before ')' Line 4710:39: E225 missing whitespace around operator Line 4712:35: E225 missing whitespace around operator Line 4714:1: E302 expected 2 blank lines, found 1

Comment last updated at 2021-08-25 14:30:57 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix dtype complex for rasterio backend 925533850
867569524 https://github.com/pydata/xarray/pull/5501#issuecomment-867569524 https://api.github.com/repos/pydata/xarray/issues/5501 MDEyOklzc3VlQ29tbWVudDg2NzU2OTUyNA== agrouaze 14925067 2021-06-24T11:42:56Z 2021-06-24T11:43:13Z NONE

Yes I can think about a test. Could this test be a simple .tiff file opening or is it too high level?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix dtype complex for rasterio backend 925533850

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);