issue_comments

Table actions

6 rows where author_association = "NONE" and issue = 657792526 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • provide set_option `collapse_html` to control HTML repr collapsed state · 6 ✖

author_association 1

  • NONE · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
667488894 https://github.com/pydata/xarray/pull/4230#issuecomment-667488894 https://api.github.com/repos/pydata/xarray/issues/4230 MDEyOklzc3VlQ29tbWVudDY2NzQ4ODg5NA== pep8speaks 24736507 2020-08-01T07:33:36Z 2021-02-27T20:54:06Z NONE

Hello @michaelaye! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-02-27 20:54:05 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   provide set_option `collapse_html` to control HTML repr collapsed state 657792526
667615325 https://github.com/pydata/xarray/pull/4230#issuecomment-667615325 https://api.github.com/repos/pydata/xarray/issues/4230 MDEyOklzc3VlQ29tbWVudDY2NzYxNTMyNQ== michaelaye 69774 2020-08-02T02:32:26Z 2020-08-02T02:32:26Z NONE

i'm fine in fixing the name of the variable, but usually open source teams don't want a PR that addresses more than one issue at a time, are you sure you want it in here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   provide set_option `collapse_html` to control HTML repr collapsed state 657792526
659135636 https://github.com/pydata/xarray/pull/4230#issuecomment-659135636 https://api.github.com/repos/pydata/xarray/issues/4230 MDEyOklzc3VlQ29tbWVudDY1OTEzNTYzNg== michaelaye 69774 2020-07-16T03:27:43Z 2020-07-16T03:27:43Z NONE

I'm looking at the relevant test function:

python def test_repr_of_dataarray(dataarray): formatted = fh.array_repr(dataarray) assert "dim_0" in formatted # has an expanded data section assert formatted.count("class='xr-array-in' type='checkbox' checked>") == 1 # coords and attrs don't have an items so they'll be be disabled and collapsed assert ( formatted.count("class='xr-section-summary-in' type='checkbox' disabled >") == 2 )

I'm not very good with HTML, does this only check on the number of collapsed sections? I am kinda guessing that this code is abusing checkbox code to make the display collapsible? How could I check specifically if the data section is collapsed based on the OPTION setting?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   provide set_option `collapse_html` to control HTML repr collapsed state 657792526
659126681 https://github.com/pydata/xarray/pull/4230#issuecomment-659126681 https://api.github.com/repos/pydata/xarray/issues/4230 MDEyOklzc3VlQ29tbWVudDY1OTEyNjY4MQ== michaelaye 69774 2020-07-16T02:55:25Z 2020-07-16T02:55:25Z NONE

Oh, implemented the wrong default, things were confusing as the HTML code "checked" for the collapsed variable apparently means NOT collapsed...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   provide set_option `collapse_html` to control HTML repr collapsed state 657792526
659121827 https://github.com/pydata/xarray/pull/4230#issuecomment-659121827 https://api.github.com/repos/pydata/xarray/issues/4230 MDEyOklzc3VlQ29tbWVudDY1OTEyMTgyNw== michaelaye 69774 2020-07-16T02:37:32Z 2020-07-16T02:37:32Z NONE

For mypy I'm getting:

bash . is not a valid Python package name

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   provide set_option `collapse_html` to control HTML repr collapsed state 657792526
659120733 https://github.com/pydata/xarray/pull/4230#issuecomment-659120733 https://api.github.com/repos/pydata/xarray/issues/4230 MDEyOklzc3VlQ29tbWVudDY1OTEyMDczMw== michaelaye 69774 2020-07-16T02:33:56Z 2020-07-16T02:35:26Z NONE

I didn't isort this commit, usually other peeps hate it when i do it, happy that you actually require it! :)

But I'm getting this return while using isort -rc . in the root repo folder (is that the idea?)

bash $ isort -rc . (xarray-tests) /home/maye/miniconda3/envs/xarray-tests/lib/python3.7/site-packages/setuptools/distutils_patch.py:26: UserWarning: Distutils was imported before Setuptools. This usage is discouraged and may exhibit undesirable behaviors or errors. Please use Setuptools' objects directly or at least import Setuptools first. "Distutils was imported before Setuptools. This usage is discouraged " Skipped 4 files

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   provide set_option `collapse_html` to control HTML repr collapsed state 657792526

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);