issue_comments

Table actions

7 rows where author_association = "NONE" and issue = 324105458 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • ENH: Plotting for groupby_bins · 7 ✖

author_association 1

  • NONE · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
428458679 https://github.com/pydata/xarray/pull/2152#issuecomment-428458679 https://api.github.com/repos/pydata/xarray/issues/2152 MDEyOklzc3VlQ29tbWVudDQyODQ1ODY3OQ== pep8speaks 24736507 2018-10-10T06:53:49Z 2018-10-23T06:44:34Z NONE

Hello @maahn! Thanks for updating the PR.

Comment last updated on October 23, 2018 at 06:44 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Plotting for groupby_bins 324105458
428629924 https://github.com/pydata/xarray/pull/2152#issuecomment-428629924 https://api.github.com/repos/pydata/xarray/issues/2152 MDEyOklzc3VlQ29tbWVudDQyODYyOTkyNA== maahn 222557 2018-10-10T16:00:14Z 2018-10-10T16:00:14Z NONE

great, thanks for taking care of that! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Plotting for groupby_bins 324105458
411840526 https://github.com/pydata/xarray/pull/2152#issuecomment-411840526 https://api.github.com/repos/pydata/xarray/issues/2152 MDEyOklzc3VlQ29tbWVudDQxMTg0MDUyNg== maahn 222557 2018-08-09T17:46:03Z 2018-08-09T17:46:03Z NONE

Sorry, for the delay, I finally merged upstream. Looks like the failed builds are unrelated to my changes, so it should be ready for merging? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Plotting for groupby_bins 324105458
395802950 https://github.com/pydata/xarray/pull/2152#issuecomment-395802950 https://api.github.com/repos/pydata/xarray/issues/2152 MDEyOklzc3VlQ29tbWVudDM5NTgwMjk1MA== maahn 222557 2018-06-08T15:46:38Z 2018-06-08T15:46:38Z NONE

Thanks for the review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Plotting for groupby_bins 324105458
394800550 https://github.com/pydata/xarray/pull/2152#issuecomment-394800550 https://api.github.com/repos/pydata/xarray/issues/2152 MDEyOklzc3VlQ29tbWVudDM5NDgwMDU1MA== maahn 222557 2018-06-05T17:49:19Z 2018-06-05T17:51:53Z NONE

Good idea, it turned out the step function was quite easy to implement by using https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/axes/_axes.py#L1735 So now, 1D data defaults to the standard line plot, but you can use plot.step() instead. I guess changing the default plot to something more sophisticated would make the simple logic in plot() to determine the default quite complex?

See https://gist.github.com/maahn/91da0a8d299ef6567827749cbe2f1913

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Plotting for groupby_bins 324105458
392944474 https://github.com/pydata/xarray/pull/2152#issuecomment-392944474 https://api.github.com/repos/pydata/xarray/issues/2152 MDEyOklzc3VlQ29tbWVudDM5Mjk0NDQ3NA== maahn 222557 2018-05-29T21:04:51Z 2018-05-29T21:04:51Z NONE

Ok, I added the interval_step_plot kwarg (default True) to the 1D line plot to make a step plot with the real (i.e. not interpolated) boundaries. After that I had the feeling that it's inconsistent if line uses the real boundaries but pcolormesh doesn't. So I also patched that, but I had to disable infer_intervals for these cases. See also: https://gist.github.com/maahn/91da0a8d299ef6567827749cbe2f1913/530ed7bf77c9c3257cab46c3894c1412085a217a

Let me know what you think and I will also add some documentation.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Plotting for groupby_bins 324105458
391026312 https://github.com/pydata/xarray/pull/2152#issuecomment-391026312 https://api.github.com/repos/pydata/xarray/issues/2152 MDEyOklzc3VlQ29tbWVudDM5MTAyNjMxMg== maahn 222557 2018-05-22T15:07:48Z 2018-05-22T15:07:48Z NONE

Thanks, for the comment, but I wouldn't use center labels when using groupby_bins by default, that could be misleading in case of non-uniform (e.g. exponential) bin spacing. I guess that's acceptable for a plot, but not for a DataArray, because the information about the boundaries would be lost. And from a user perspective, I would find it a bit confusing if an additional coordinate would show up when using groupby_bins. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Plotting for groupby_bins 324105458

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);