issue_comments

Table actions

1 row where author_association = "NONE", issue = 314764258 and user = 40172290 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • henrikca · 1 ✖

issue 1

  • concat_dim getting added to *all* variables of multifile datasets · 1 ✖

author_association 1

  • NONE · 1 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
399954316 https://github.com/pydata/xarray/issues/2064#issuecomment-399954316 https://api.github.com/repos/pydata/xarray/issues/2064 MDEyOklzc3VlQ29tbWVudDM5OTk1NDMxNg== henrikca 40172290 2018-06-25T13:37:04Z 2018-06-25T13:37:04Z NONE

I recently ran into a similar issue and found a potential solution.

The functionality, as far as I understand, is already in the open_mfdataset function in the data_vars ='minimal' argument, in this case variables without concat_dim are included without adding the dimension. The current default is data_vars ='all' which include all variables with the added dimension. If the desired functionality shouldn't implicitly add new dimensions shouldn't the default be set to 'minimal' instead?

I think this is a very non-intrusive solution since it only affects the open_mfdataset function, and if you for some reason want the old behavior it is still there. An alternative way is to rewrite the _dataset_concat function I guess.

This is my first time attempting to contribute, does this sound like a good idea? I can try to make a pull request but would very much value some input first.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   concat_dim getting added to *all* variables of multifile datasets 314764258

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);