issue_comments

Table actions

5 rows where author_association = "NONE", issue = 270677100 and user = 10137 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • ghost · 5 ✖

issue 1

  • Add option “engine” · 5 ✖

author_association 1

  • NONE · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
355678395 https://github.com/pydata/xarray/pull/1682#issuecomment-355678395 https://api.github.com/repos/pydata/xarray/issues/1682 MDEyOklzc3VlQ29tbWVudDM1NTY3ODM5NQ== ghost 10137 2018-01-05T22:07:03Z 2018-01-05T22:07:03Z NONE

Now that the tests are passing again, is there anything else left to change?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add option “engine” 270677100
351810655 https://github.com/pydata/xarray/pull/1682#issuecomment-351810655 https://api.github.com/repos/pydata/xarray/issues/1682 MDEyOklzc3VlQ29tbWVudDM1MTgxMDY1NQ== ghost 10137 2017-12-14T19:25:03Z 2017-12-14T19:25:03Z NONE

I've refactored setting the I/O engine option as per our discussion. Hopefully, it captures now all the requested functionality.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add option “engine” 270677100
347917241 https://github.com/pydata/xarray/pull/1682#issuecomment-347917241 https://api.github.com/repos/pydata/xarray/issues/1682 MDEyOklzc3VlQ29tbWVudDM0NzkxNzI0MQ== ghost 10137 2017-11-29T16:32:56Z 2017-11-29T16:32:56Z NONE

Let's see if we can get this PR over the line... 😄

A list of engines would need some way of declaring their I/O capabilities: only file-based, only HTTP-based, or both. Something like:

```python io_engines = [ {'engine': 'netcdf4', 'capabilities': ['file', 'http']},

{'engine': 'pydap', 
 'capabilities': ['http']},

{'engine': 'scipy', 
 'capabilities': ['file']},

{'engine': 'h5netcdf',
 'capabilities': ['file']},

] ```

On xarray import or any time this option would change, the list of engines would be checked to remove unavailable engines.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add option “engine” 270677100
341773389 https://github.com/pydata/xarray/pull/1682#issuecomment-341773389 https://api.github.com/repos/pydata/xarray/issues/1682 MDEyOklzc3VlQ29tbWVudDM0MTc3MzM4OQ== ghost 10137 2017-11-03T17:30:18Z 2017-11-03T17:30:18Z NONE

Yes, there could be more I/O engine options. How about file_engine and web_engine? Keeping the naming more generic as there may be other file-based formats or data web services in the future.

On the other hand, setting this global option should indicate a willingness to accept the consequences. If automatic selection of the optional I/O engine is preferred, this global option should not be set.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add option “engine” 270677100
341610428 https://github.com/pydata/xarray/pull/1682#issuecomment-341610428 https://api.github.com/repos/pydata/xarray/issues/1682 MDEyOklzc3VlQ29tbWVudDM0MTYxMDQyOA== ghost 10137 2017-11-03T02:35:14Z 2017-11-03T02:35:14Z NONE

How about io_engine for the option's name? The data can come from an OPeNDAP server as well.

I have reverted to the original engine=None in the functions/methods and use python engine = engine or OPTIONS['io_engine'] to assign the correct engine value.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add option “engine” 270677100

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);