issue_comments

Table actions

2 rows where author_association = "NONE", issue = 157545837 and user = 6079398 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • mogismog · 2 ✖

issue 1

  • decode_cf not concatenating string arrays · 2 ✖

author_association 1

  • NONE · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
224949305 https://github.com/pydata/xarray/issues/862#issuecomment-224949305 https://api.github.com/repos/pydata/xarray/issues/862 MDEyOklzc3VlQ29tbWVudDIyNDk0OTMwNQ== mogismog 6079398 2016-06-09T16:26:36Z 2016-06-09T16:26:36Z NONE

This seems a little too magical to me. How would we know if the dataset dimension was added intentionally or not?

Yeah, that's a fair point. I'll put together something that uses an optional list of dimensions to concatenate over. Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   decode_cf not concatenating string arrays 157545837
224787831 https://github.com/pydata/xarray/issues/862#issuecomment-224787831 https://api.github.com/repos/pydata/xarray/issues/862 MDEyOklzc3VlQ29tbWVudDIyNDc4NzgzMQ== mogismog 6079398 2016-06-09T02:51:11Z 2016-06-09T02:51:52Z NONE

Hey @shoyer,

Sorry for the delayed response. Passing a list of dimensions over which to concatenate over seems like it would be the easiest workaround with the fewest questions asked. As you mentioned, every dimension gets a variable by the time it is a dataset, so another option (that I'll admit I haven't thought all the way through and may not even work) would be to first check if decode_cf is working on a Dataset or AbstractDataStore (e: which it already does anyway), and then decide whether to concatenate over a dimension or not. I could see the latter idea not working out so well, but I'd be curious about your thoughts.

Either way, I can put something together this week and open up a PR. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   decode_cf not concatenating string arrays 157545837

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);