issue_comments

Table actions

4 rows where author_association = "NONE" and issue = 146079798 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • modified: xarray/backends/api.py · 4 ✖

author_association 1

  • NONE · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
388749495 https://github.com/pydata/xarray/pull/817#issuecomment-388749495 https://api.github.com/repos/pydata/xarray/issues/817 MDEyOklzc3VlQ29tbWVudDM4ODc0OTQ5NQ== tsaoyu 6488896 2018-05-14T09:11:08Z 2018-05-14T09:11:08Z NONE

I am trying to understand the logic by looking through the comments/discussion on this commit. After two years of development, there are quite some changes on the API itself e.g. the logic on the gzipped file handling seems already moved from api.py to scipy_.py. So I think it would be better to start a new commit from the latest version.

To bring the concept on the same table, there are 3 backends that can be used to handle gzipped netCDF file namely scipy, netcdf4 and pydap. scipy backend only support netCDF3 so far and that is the only implemented method to handle gzipped netCDF3 file. netcdf4 and pydap should able to deal with netCDF4 file given the file is first opened by gzip.open (as it was implement in scipy_.py).

So what we need to do is to make both netCDF4_.py and pydap_.py aware of the file is end with .gz and first open it using gzip.open. Following tests also need to be done to verify the implementation of the logic. I have looked at vcrpy and it seems a nice idea to speed up tests with HTTP stuff involved. I must confess I only use xarray with local file so it may takes quite a while to understand the issue. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   modified: xarray/backends/api.py 146079798
388386642 https://github.com/pydata/xarray/pull/817#issuecomment-388386642 https://api.github.com/repos/pydata/xarray/issues/817 MDEyOklzc3VlQ29tbWVudDM4ODM4NjY0Mg== tsaoyu 6488896 2018-05-11T14:49:48Z 2018-05-11T14:49:48Z NONE

How is this issue progressed so far? I am running into the same problem now and I might able to offer some help in testing. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   modified: xarray/backends/api.py 146079798
206470775 https://github.com/pydata/xarray/pull/817#issuecomment-206470775 https://api.github.com/repos/pydata/xarray/issues/817 MDEyOklzc3VlQ29tbWVudDIwNjQ3MDc3NQ== swnesbitt 3288592 2016-04-06T17:15:57Z 2016-04-06T17:15:57Z NONE

OK - understood. Incidentally, I didn't include pydap because it doesn't seem to be python 3.* compatible. I tested it on 2.7 for my application and it seems to work.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   modified: xarray/backends/api.py 146079798
206461095 https://github.com/pydata/xarray/pull/817#issuecomment-206461095 https://api.github.com/repos/pydata/xarray/issues/817 MDEyOklzc3VlQ29tbWVudDIwNjQ2MTA5NQ== swnesbitt 3288592 2016-04-06T16:49:24Z 2016-04-06T16:49:24Z NONE

Certainly can take a crack at this. This is working for my application, but would be good to clean up the code to simplify the cases as you suggest.

Regarding testing, it would be good to have a test module that includes grabbing files for local access and accessing openDAP datasets (from UNIDATA?) to ensure that the installed backends are all working as expected.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   modified: xarray/backends/api.py 146079798

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);