issue_comments

Table actions

4 rows where author_association = "NONE" and issue = 128980804 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Cannot inherit DataArray anymore in 0.7 release · 4 ✖

author_association 1

  • NONE · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
193930364 https://github.com/pydata/xarray/issues/728#issuecomment-193930364 https://api.github.com/repos/pydata/xarray/issues/728 MDEyOklzc3VlQ29tbWVudDE5MzkzMDM2NA== MathieuSchopfer 17726101 2016-03-08T19:23:37Z 2016-03-08T19:23:37Z NONE

That's the point of this issue, why. Read this comment of @shoyer.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot inherit DataArray anymore in 0.7 release 128980804
193883587 https://github.com/pydata/xarray/issues/728#issuecomment-193883587 https://api.github.com/repos/pydata/xarray/issues/728 MDEyOklzc3VlQ29tbWVudDE5Mzg4MzU4Nw== MathieuSchopfer 17726101 2016-03-08T17:39:07Z 2016-03-08T17:39:07Z NONE

@MaximilianR Okay, but this won't solve the current issue. If you override the __init__ method when trying to subclass DataArray, subsequent accesses to some attributes (e.g. coords) will fail. No matter if you super up or not.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot inherit DataArray anymore in 0.7 release 128980804
193869538 https://github.com/pydata/xarray/issues/728#issuecomment-193869538 https://api.github.com/repos/pydata/xarray/issues/728 MDEyOklzc3VlQ29tbWVudDE5Mzg2OTUzOA== MathieuSchopfer 17726101 2016-03-08T17:03:33Z 2016-03-08T17:03:33Z NONE

Well, I think pure OOP should support class inheritance. In this case, you can subclass DataArray only if you do not customise the __init__ method, which is not true inheritance ...

Yes, I have an alternative to suggest: initialise subclass instances in two steps, by creating a public method init(self, ...) or initialise(self, ...) to set custom attributes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot inherit DataArray anymore in 0.7 release 128980804
193846664 https://github.com/pydata/xarray/issues/728#issuecomment-193846664 https://api.github.com/repos/pydata/xarray/issues/728 MDEyOklzc3VlQ29tbWVudDE5Mzg0NjY2NA== MathieuSchopfer 17726101 2016-03-08T16:21:55Z 2016-03-08T16:24:32Z NONE

@shoyer Then it is not OOP any more ...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot inherit DataArray anymore in 0.7 release 128980804

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);