issue_comments
8 rows where author_association = "MEMBER" and issue = 942738904 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: reactions, created_at (date), updated_at (date)
issue 1
- Decoding netCDF is giving incorrect values for a large file · 8 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
1492937244 | https://github.com/pydata/xarray/issues/5597#issuecomment-1492937244 | https://api.github.com/repos/pydata/xarray/issues/5597 | IC_kwDOAMm_X85Y_Goc | kmuehlbauer 5821660 | 2023-04-01T11:03:02Z | 2023-04-01T11:03:02Z | MEMBER |
This is aimed at in #7654 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Decoding netCDF is giving incorrect values for a large file 942738904 | |
879561954 | https://github.com/pydata/xarray/issues/5597#issuecomment-879561954 | https://api.github.com/repos/pydata/xarray/issues/5597 | MDEyOklzc3VlQ29tbWVudDg3OTU2MTk1NA== | shoyer 1217238 | 2021-07-14T03:43:37Z | 2021-07-14T03:44:00Z | MEMBER | Thanks for sharing the subset netCDF file, that is very helpful for debugging indeed! The weird thing is that the dtype picking logic seems to have a special case that, per the code comment, suggesting we want to be using float64 here: https://github.com/pydata/xarray/blob/eea76733770be03e78a0834803291659136bca31/xarray/coding/variables.py#L231-L238 But in fact, the dtype picking logic doesn't do that, because the dtype is already converted into float32, first. The culprit seems to be this line in CFMaskCoder, which promotes the dtype to float32 to fit a fill-value of NaN: https://github.com/pydata/xarray/blob/eea76733770be03e78a0834803291659136bca31/xarray/coding/variables.py#L202 To fix this, I think logic in |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Decoding netCDF is giving incorrect values for a large file 942738904 | |
879361320 | https://github.com/pydata/xarray/issues/5597#issuecomment-879361320 | https://api.github.com/repos/pydata/xarray/issues/5597 | MDEyOklzc3VlQ29tbWVudDg3OTM2MTMyMA== | shoyer 1217238 | 2021-07-13T19:58:39Z | 2021-07-13T19:58:39Z | MEMBER | This may just be the expected floating point error from using float32: ``` In [5]: import numpy as np In [6]: -32766 * np.float32(625.6492454183389) + np.float32(20500023.17537729) Out[6]: 1.2984619140625 ``` If you use full float64, then the data does decode to 0.0:
So the question then is why this ends up being decoded using float32 instead of float64, and if that logic should be adjusted or made customizable: https://github.com/pydata/xarray/blob/eea76733770be03e78a0834803291659136bca31/xarray/coding/variables.py#L225 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Decoding netCDF is giving incorrect values for a large file 942738904 | |
879199563 | https://github.com/pydata/xarray/issues/5597#issuecomment-879199563 | https://api.github.com/repos/pydata/xarray/issues/5597 | MDEyOklzc3VlQ29tbWVudDg3OTE5OTU2Mw== | keewis 14808389 | 2021-07-13T15:45:05Z | 2021-07-13T15:45:05Z | MEMBER | can you post the value of |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Decoding netCDF is giving incorrect values for a large file 942738904 | |
878914016 | https://github.com/pydata/xarray/issues/5597#issuecomment-878914016 | https://api.github.com/repos/pydata/xarray/issues/5597 | MDEyOklzc3VlQ29tbWVudDg3ODkxNDAxNg== | kmuehlbauer 5821660 | 2021-07-13T09:07:14Z | 2021-07-13T09:07:14Z | MEMBER | @ohsqueezy You might also try |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Decoding netCDF is giving incorrect values for a large file 942738904 | |
878833159 | https://github.com/pydata/xarray/issues/5597#issuecomment-878833159 | https://api.github.com/repos/pydata/xarray/issues/5597 | MDEyOklzc3VlQ29tbWVudDg3ODgzMzE1OQ== | max-sixty 5635139 | 2021-07-13T07:03:43Z | 2021-07-13T07:03:43Z | MEMBER | Thanks. Does passing different values to |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Decoding netCDF is giving incorrect values for a large file 942738904 | |
878830308 | https://github.com/pydata/xarray/issues/5597#issuecomment-878830308 | https://api.github.com/repos/pydata/xarray/issues/5597 | MDEyOklzc3VlQ29tbWVudDg3ODgzMDMwOA== | kmuehlbauer 5821660 | 2021-07-13T06:58:24Z | 2021-07-13T06:58:24Z | MEMBER | @ohsqueezy Does this issue also show up, if just plain netCDF4 is used to open the files? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Decoding netCDF is giving incorrect values for a large file 942738904 | |
878792388 | https://github.com/pydata/xarray/issues/5597#issuecomment-878792388 | https://api.github.com/repos/pydata/xarray/issues/5597 | MDEyOklzc3VlQ29tbWVudDg3ODc5MjM4OA== | max-sixty 5635139 | 2021-07-13T05:32:27Z | 2021-07-13T05:32:27Z | MEMBER | A small question to clarify:
Is that the output of the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Decoding netCDF is giving incorrect values for a large file 942738904 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 4