issue_comments

Table actions

4 rows where author_association = "MEMBER", issue = 929840699 and user = 10194086 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • mathause · 4 ✖

issue 1

  • Keyword only args for arguments like "drop" · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1213078538 https://github.com/pydata/xarray/issues/5531#issuecomment-1213078538 https://api.github.com/repos/pydata/xarray/issues/5531 IC_kwDOAMm_X85IThwK mathause 10194086 2022-08-12T12:51:30Z 2022-08-12T12:51:30Z MEMBER

I just opened #6910 - feedback welcome.

These decorators are kinda fun to write and are quite taylored to a certain release philosophy. It might be warranted to just write your own ;)

I am glad that's fine for you.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Keyword only args for arguments like "drop" 929840699
1211959725 https://github.com/pydata/xarray/issues/5531#issuecomment-1211959725 https://api.github.com/repos/pydata/xarray/issues/5531 IC_kwDOAMm_X85IPQmt mathause 10194086 2022-08-11T13:02:19Z 2022-08-11T13:02:31Z MEMBER

I just realized that @hmaarrfk's decorator works similarly, but it also has some bells and whistles we probably don't need..?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Keyword only args for arguments like "drop" 929840699
1211288085 https://github.com/pydata/xarray/issues/5531#issuecomment-1211288085 https://api.github.com/repos/pydata/xarray/issues/5531 IC_kwDOAMm_X85IMsoV mathause 10194086 2022-08-10T21:20:32Z 2022-08-10T21:20:32Z MEMBER

I just discovered the scikit-learns decorator to deprecate positional args - see https://github.com/scikit-learn/scikit-learn/pull/13311 - and now have a preference for this one. It seems the simplest and does not need any input as it reads the keyword-only args from the signature (could potentially add the version of the deprecation).

python @_deprecate_positional_args def f1(a, b, *, c=1, d=1): pass

and at the end of the deprecation period you only need to do

diff -@_deprecate_positional_args def f1(a, b, *, c=1, d=1): pass

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Keyword only args for arguments like "drop" 929840699
1102960326 https://github.com/pydata/xarray/issues/5531#issuecomment-1102960326 https://api.github.com/repos/pydata/xarray/issues/5531 IC_kwDOAMm_X85BvdbG mathause 10194086 2022-04-19T18:31:32Z 2022-04-19T18:31:32Z MEMBER

Both look good - but adding an intermittent dependency seems a bit heavy...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Keyword only args for arguments like "drop" 929840699

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);