issue_comments

Table actions

6 rows where author_association = "MEMBER" and issue = 925444927 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Add `typing-extensions` to the list of dependencies? · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
894668924 https://github.com/pydata/xarray/issues/5495#issuecomment-894668924 https://api.github.com/repos/pydata/xarray/issues/5495 IC_kwDOAMm_X841U5B8 max-sixty 5635139 2021-08-07T15:28:39Z 2021-08-07T15:28:39Z MEMBER

As soon as libraries like Beam allow installing later versions, I would vote to add this back.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `typing-extensions` to the list of dependencies? 925444927
894616596 https://github.com/pydata/xarray/issues/5495#issuecomment-894616596 https://api.github.com/repos/pydata/xarray/issues/5495 IC_kwDOAMm_X841UsQU Illviljan 14371165 2021-08-07T07:05:12Z 2021-08-07T07:05:12Z MEMBER

Using typing_extensions seems to be a nice way to get backwards compatibility with older python versions. I can see some typing bugs slipping through rather easily onsidering how picky mypy is and the CI doesn't do mypy checks on all python versions.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `typing-extensions` to the list of dependencies? 925444927
883576575 https://github.com/pydata/xarray/issues/5495#issuecomment-883576575 https://api.github.com/repos/pydata/xarray/issues/5495 IC_kwDOAMm_X840qk7_ shoyer 1217238 2021-07-20T17:43:42Z 2021-07-20T17:43:42Z MEMBER

I made an attempt at making the use of TypeGuard optional, but it doesn't pass mypy yet: https://github.com/pydata/xarray/pull/5624

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `typing-extensions` to the list of dependencies? 925444927
881786427 https://github.com/pydata/xarray/issues/5495#issuecomment-881786427 https://api.github.com/repos/pydata/xarray/issues/5495 IC_kwDOAMm_X840jv47 shoyer 1217238 2021-07-17T00:44:02Z 2021-07-17T00:44:02Z MEMBER

Can we consider making typing-extensions a fully optional dependency instead?

In particular, typing-extensions 3.10 is a very new version, only from May 2021. This seems overly restrictive, particularly for a dependency that isn't really needed at all at runtime and that we only use for a few type annotations.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `typing-extensions` to the list of dependencies? 925444927
864477718 https://github.com/pydata/xarray/issues/5495#issuecomment-864477718 https://api.github.com/repos/pydata/xarray/issues/5495 MDEyOklzc3VlQ29tbWVudDg2NDQ3NzcxOA== max-sixty 5635139 2021-06-19T23:59:27Z 2021-06-19T23:59:27Z MEMBER

Yes, good point.

Would you be up for another PR @malmans2 ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `typing-extensions` to the list of dependencies? 925444927
864464733 https://github.com/pydata/xarray/issues/5495#issuecomment-864464733 https://api.github.com/repos/pydata/xarray/issues/5495 MDEyOklzc3VlQ29tbWVudDg2NDQ2NDczMw== max-sixty 5635139 2021-06-19T21:16:24Z 2021-06-19T21:16:24Z MEMBER

Great spot! We should definitely add that.

I wonder how CI passes, then?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `typing-extensions` to the list of dependencies? 925444927

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);