issue_comments
14 rows where author_association = "MEMBER" and issue = 889162918 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: reactions, created_at (date), updated_at (date)
issue 1
- ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument · 14 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
841532936 | https://github.com/pydata/xarray/issues/5291#issuecomment-841532936 | https://api.github.com/repos/pydata/xarray/issues/5291 | MDEyOklzc3VlQ29tbWVudDg0MTUzMjkzNg== | max-sixty 5635139 | 2021-05-14T22:28:13Z | 2021-05-14T22:28:13Z | MEMBER | Thanks. Agree it's not worth that lift. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument 889162918 | |
841519845 | https://github.com/pydata/xarray/issues/5291#issuecomment-841519845 | https://api.github.com/repos/pydata/xarray/issues/5291 | MDEyOklzc3VlQ29tbWVudDg0MTUxOTg0NQ== | shoyer 1217238 | 2021-05-14T21:48:19Z | 2021-05-14T21:48:19Z | MEMBER |
I don't think this is possible currently with I think it can be done with |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument 889162918 | |
841472615 | https://github.com/pydata/xarray/issues/5291#issuecomment-841472615 | https://api.github.com/repos/pydata/xarray/issues/5291 | MDEyOklzc3VlQ29tbWVudDg0MTQ3MjYxNQ== | max-sixty 5635139 | 2021-05-14T20:03:23Z | 2021-05-14T20:03:23Z | MEMBER |
My question is whether we can make xarray by default pull the equivalent of |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument 889162918 | |
841428456 | https://github.com/pydata/xarray/issues/5291#issuecomment-841428456 | https://api.github.com/repos/pydata/xarray/issues/5291 | MDEyOklzc3VlQ29tbWVudDg0MTQyODQ1Ng== | shoyer 1217238 | 2021-05-14T18:37:11Z | 2021-05-14T18:37:41Z | MEMBER |
|
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument 889162918 | |
841428388 | https://github.com/pydata/xarray/issues/5291#issuecomment-841428388 | https://api.github.com/repos/pydata/xarray/issues/5291 | MDEyOklzc3VlQ29tbWVudDg0MTQyODM4OA== | keewis 14808389 | 2021-05-14T18:37:02Z | 2021-05-14T18:37:02Z | MEMBER | It is pretty light but pulls in a few additional dependencies. For normal python package managers (i.e. pip / poetry / etc.) we can probably take advantage of the We could also change the current message ("using the tutorial data requires pooch") to something like
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument 889162918 | |
841423655 | https://github.com/pydata/xarray/issues/5291#issuecomment-841423655 | https://api.github.com/repos/pydata/xarray/issues/5291 | MDEyOklzc3VlQ29tbWVudDg0MTQyMzY1NQ== | max-sixty 5635139 | 2021-05-14T18:27:53Z | 2021-05-14T18:27:53Z | MEMBER | Thanks a lot @shoyer . Is there a way of having It's a pretty light dependency, and it's unfortunate to add any sand into the gears of getting someone to the tutorial. (though an order of magnitude better since the change above) |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument 889162918 | |
840900432 | https://github.com/pydata/xarray/issues/5291#issuecomment-840900432 | https://api.github.com/repos/pydata/xarray/issues/5291 | MDEyOklzc3VlQ29tbWVudDg0MDkwMDQzMg== | shoyer 1217238 | 2021-05-13T23:55:20Z | 2021-05-13T23:55:20Z | MEMBER | I've added a temporary work-around to provide better errors for the tutorial datasets into #5300, i.e., solution (3) from my previouso comment. This is challenging to unit-test, so I'll just share my IPython session(s) from a new environment to show how it works: ``` (xarray-min) ~/dev/xarray better-no-plugins-errors $ ipython Python 3.9.4 (default, Apr 9 2021, 09:32:38) Type 'copyright', 'credits' or 'license' for more information IPython 7.22.0 -- An enhanced Interactive Python. Type '?' for help. In [1]: import xarray In [2]: xarray.tutorial.open_dataset('air_temperature')ModuleNotFoundError Traceback (most recent call last) ~/dev/xarray/xarray/tutorial.py in open_dataset(name, cache, cache_dir, engine, **kws) 113 try: --> 114 import pooch 115 except ImportError: ModuleNotFoundError: No module named 'pooch' During handling of the above exception, another exception occurred: ImportError Traceback (most recent call last) <ipython-input-2-e970a0b41221> in <module> ----> 1 xarray.tutorial.open_dataset('air_temperature') ~/dev/xarray/xarray/tutorial.py in open_dataset(name, cache, cache_dir, engine, **kws) 114 import pooch 115 except ImportError: --> 116 raise ImportError("using the tutorial data requires pooch") 117 118 logger = pooch.get_logger() ImportError: using the tutorial data requires pooch In [3]: ! pip install pooch Collecting pooch Using cached pooch-1.3.0-py3-none-any.whl (51 kB) Requirement already satisfied: requests in /Users/shoyer/miniconda3/envs/xarray-min/lib/python3.9/site-packages (from pooch) (2.25.1) Requirement already satisfied: appdirs in /Users/shoyer/miniconda3/envs/xarray-min/lib/python3.9/site-packages (from pooch) (1.4.4) Requirement already satisfied: packaging in /Users/shoyer/miniconda3/envs/xarray-min/lib/python3.9/site-packages (from pooch) (20.9) Requirement already satisfied: pyparsing>=2.0.2 in /Users/shoyer/miniconda3/envs/xarray-min/lib/python3.9/site-packages (from packaging->pooch) (2.4.7) Requirement already satisfied: certifi>=2017.4.17 in /Users/shoyer/miniconda3/envs/xarray-min/lib/python3.9/site-packages (from requests->pooch) (2020.12.5) Requirement already satisfied: urllib3<1.27,>=1.21.1 in /Users/shoyer/miniconda3/envs/xarray-min/lib/python3.9/site-packages (from requests->pooch) (1.26.4) Requirement already satisfied: idna<3,>=2.5 in /Users/shoyer/miniconda3/envs/xarray-min/lib/python3.9/site-packages (from requests->pooch) (2.10) Requirement already satisfied: chardet<5,>=3.0.2 in /Users/shoyer/miniconda3/envs/xarray-min/lib/python3.9/site-packages (from requests->pooch) (4.0.0) Installing collected packages: pooch Successfully installed pooch-1.3.0 In [4]: xarray.tutorial.open_dataset('air_temperature')ModuleNotFoundError Traceback (most recent call last) ~/dev/xarray/xarray/tutorial.py in _check_netcdf_engine_installed(name) 51 try: ---> 52 import scipy 53 except ImportError: ModuleNotFoundError: No module named 'scipy' During handling of the above exception, another exception occurred: ModuleNotFoundError Traceback (most recent call last) ~/dev/xarray/xarray/tutorial.py in _check_netcdf_engine_installed(name) 54 try: ---> 55 import netCDF4 56 except ImportError: ModuleNotFoundError: No module named 'netCDF4' During handling of the above exception, another exception occurred: ImportError Traceback (most recent call last) <ipython-input-4-e970a0b41221> in <module> ----> 1 xarray.tutorial.open_dataset('air_temperature') ~/dev/xarray/xarray/tutorial.py in open_dataset(name, cache, cache_dir, engine, **kws) 128 default_extension = ".nc" 129 if engine is None: --> 130 _check_netcdf_engine_installed(name) 131 path = path.with_suffix(default_extension) 132 elif path.suffix == ".grib": ~/dev/xarray/xarray/tutorial.py in _check_netcdf_engine_installed(name) 55 import netCDF4 56 except ImportError: ---> 57 raise ImportError( 58 f"opening tutorial dataset {name} requires either scipy or " 59 "netCDF4 to be installed." ImportError: opening tutorial dataset air_temperature requires either scipy or netCDF4 to be installed. In [5]: ! pip install netcdf4 Collecting netcdf4 Using cached netCDF4-1.5.6-cp39-cp39-macosx_10_9_x86_64.whl (4.0 MB) Requirement already satisfied: numpy>=1.9 in /Users/shoyer/miniconda3/envs/xarray-min/lib/python3.9/site-packages (from netcdf4) (1.20.1) Requirement already satisfied: cftime in /Users/shoyer/miniconda3/envs/xarray-min/lib/python3.9/site-packages (from netcdf4) (1.4.1) Installing collected packages: netcdf4 Successfully installed netcdf4-1.5.6 In [6]: xarray.tutorial.open_dataset('air_temperature')ValueError Traceback (most recent call last) <ipython-input-6-e970a0b41221> in <module> ----> 1 xarray.tutorial.open_dataset('air_temperature') ~/dev/xarray/xarray/tutorial.py in open_dataset(name, cache, cache_dir, engine, kws) 138 # retrieve the file 139 filepath = pooch.retrieve(url=url, known_hash=None, path=cache_dir) --> 140 ds = _open_dataset(filepath, engine=engine, kws) 141 if not cache: 142 ds = ds.load() ~/dev/xarray/xarray/backends/api.py in open_dataset(filename_or_obj, engine, chunks, cache, decode_cf, mask_and_scale, decode_times, decode_timedelta, use_cftime, concat_characters, decode_coords, drop_variables, backend_kwargs, args, *kwargs) 478 479 if engine is None: --> 480 engine = plugins.guess_engine(filename_or_obj) 481 482 backend = plugins.get_backend(engine) ~/dev/xarray/xarray/backends/plugins.py in guess_engine(store_spec) 118 ) 119 else: --> 120 raise ValueError( 121 "xarray is unable to open this file because it has no currently " 122 "installed IO backends. Xarray's read/write support requires " ValueError: xarray is unable to open this file because it has no currently installed IO backends. Xarray's read/write support requires installing optional dependencies: http://xarray.pydata.org/en/stable/getting-started-guide/installing.html http://xarray.pydata.org/en/stable/user-guide/io.html In [7]: Do you really want to exit ([y]/n)? y (xarray-min) ~/dev/xarray better-no-plugins-errors $ ipython Python 3.9.4 (default, Apr 9 2021, 09:32:38) Type 'copyright', 'credits' or 'license' for more information IPython 7.22.0 -- An enhanced Interactive Python. Type '?' for help. In [1]: import xarray In [2]: xarray.tutorial.open_dataset('air_temperature') Out[2]: <xarray.Dataset> Dimensions: (lat: 25, lon: 53, time: 2920) Coordinates: * lat (lat) float32 75.0 72.5 70.0 67.5 65.0 ... 25.0 22.5 20.0 17.5 15.0 * lon (lon) float32 200.0 202.5 205.0 207.5 ... 322.5 325.0 327.5 330.0 * time (time) datetime64[ns] 2013-01-01 ... 2014-12-31T18:00:00 Data variables: air (time, lat, lon) float32 ... Attributes: Conventions: COARDS title: 4x daily NMC reanalysis (1948) description: Data is from NMC initialized reanalysis\n(4x/day). These a... platform: Model references: http://www.esrl.noaa.gov/psd/data/gridded/data.ncep.reanaly... ``` This isn't quite perfect -- the user needs to restart their session to actually load the data -- but hopefully this is much more obvious and roughly within user expectations. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument 889162918 | |
840738270 | https://github.com/pydata/xarray/issues/5291#issuecomment-840738270 | https://api.github.com/repos/pydata/xarray/issues/5291 | MDEyOklzc3VlQ29tbWVudDg0MDczODI3MA== | shoyer 1217238 | 2021-05-13T18:13:26Z | 2021-05-13T18:13:26Z | MEMBER | CC @alexamici @aurghs I would suggest three levels of fixes:
If we do a nice job of (2) than maybe (3) will not be necessary. I'll open a new issue to discuss my proposed solution for (2). |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument 889162918 | |
839411182 | https://github.com/pydata/xarray/issues/5291#issuecomment-839411182 | https://api.github.com/repos/pydata/xarray/issues/5291 | MDEyOklzc3VlQ29tbWVudDgzOTQxMTE4Mg== | shoyer 1217238 | 2021-05-12T03:49:35Z | 2021-05-12T03:49:35Z | MEMBER | Good point -- in this case specifying an engine explicitly cannot help, because the required engine is not installed. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument 889162918 | |
839406401 | https://github.com/pydata/xarray/issues/5291#issuecomment-839406401 | https://api.github.com/repos/pydata/xarray/issues/5291 | MDEyOklzc3VlQ29tbWVudDgzOTQwNjQwMQ== | max-sixty 5635139 | 2021-05-12T03:32:11Z | 2021-05-12T03:32:11Z | MEMBER |
Yes and is this a problem with passing an engine? Could doing what it says ("passing one explicitly") make it work? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument 889162918 | |
839373887 | https://github.com/pydata/xarray/issues/5291#issuecomment-839373887 | https://api.github.com/repos/pydata/xarray/issues/5291 | MDEyOklzc3VlQ29tbWVudDgzOTM3Mzg4Nw== | shoyer 1217238 | 2021-05-12T01:58:13Z | 2021-05-12T01:58:13Z | MEMBER | This is indeed unfortunate, thanks for the report! I believe But if you don't have either scipy or netCDF4 installed, you get the very unhelpful error message At the very least, we should report which engines are installed -- and ideally make a specific recommendation like installing scipy or netCDF4. |
{ "total_count": 4, "+1": 4, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument 889162918 | |
839334583 | https://github.com/pydata/xarray/issues/5291#issuecomment-839334583 | https://api.github.com/repos/pydata/xarray/issues/5291 | MDEyOklzc3VlQ29tbWVudDgzOTMzNDU4Mw== | scottyhq 3924836 | 2021-05-12T00:31:28Z | 2021-05-12T00:31:28Z | MEMBER | Thanks @keewis I should have been more clear about the environment. I was recently going over the tutorial with someone and started with:
I do think these error messages are not obvious to fix for new xarray users trying out the tutorial (especially # 3 above)
Yes. Perhaps with a link to docs with a list of engines? for the tutorial case specifically could also update the ImportError message to read |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument 889162918 | |
839317175 | https://github.com/pydata/xarray/issues/5291#issuecomment-839317175 | https://api.github.com/repos/pydata/xarray/issues/5291 | MDEyOklzc3VlQ29tbWVudDgzOTMxNzE3NQ== | keewis 14808389 | 2021-05-12T00:12:26Z | 2021-05-12T00:17:58Z | MEMBER | I think there's something wrong with your environment: I can't reproduce in a environment created by
Edit: you could also try clearing |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument 889162918 | |
839319221 | https://github.com/pydata/xarray/issues/5291#issuecomment-839319221 | https://api.github.com/repos/pydata/xarray/issues/5291 | MDEyOklzc3VlQ29tbWVudDgzOTMxOTIyMQ== | keewis 14808389 | 2021-05-12T00:15:29Z | 2021-05-12T00:15:29Z | MEMBER | we could definitely improve the error message, though. Something like "unknown engine {engine}, please choose one of the installed engines: {engines}", maybe? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument 889162918 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 4