issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 879033384 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • max-sixty · 3 ✖

issue 1

  • DataArray.clip() no longer supports the out argument · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
835558405 https://github.com/pydata/xarray/issues/5278#issuecomment-835558405 https://api.github.com/repos/pydata/xarray/issues/5278 MDEyOklzc3VlQ29tbWVudDgzNTU1ODQwNQ== max-sixty 5635139 2021-05-08T22:55:17Z 2021-05-08T22:55:17Z MEMBER

Thanks @keewis , that makes sense.

And ensuring I return to @seth-p 's original issue — I would be up for adding out if we're violating the __array_wrap__ standard by not having all its kwargs.

Otherwise I would vote weakly against out throughout xarray's API, and strongly against it out on an arbitrary subset of methods.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.clip() no longer supports the out argument 879033384
835518391 https://github.com/pydata/xarray/issues/5278#issuecomment-835518391 https://api.github.com/repos/pydata/xarray/issues/5278 MDEyOklzc3VlQ29tbWVudDgzNTUxODM5MQ== max-sixty 5635139 2021-05-08T21:18:14Z 2021-05-08T22:37:28Z MEMBER

Thanks for the example @raybellwaves

Supporting np.{func} would be good — I have only partially followed the interop with numpy — e.g. __array_ufunc__ (edit: __array_function__) — is anyone familiar with whether we're violating the standards by not having an out arg with clip?

FYI, we don't generally have out args, but we do have them in nanops.py:

xarray/core/nanops.py: 78: def nanmin(a, axis=None, out=None): 86: def nanmax(a, axis=None, out=None): 112: def nansum(a, axis=None, dtype=None, out=None, min_count=None): 137: def nanmean(a, axis=None, dtype=None, out=None): 151: def nanmedian(a, axis=None, out=None): 169: def nanvar(a, axis=None, dtype=None, out=None, ddof=0): 178: def nanstd(a, axis=None, dtype=None, out=None, ddof=0): 184: def nanprod(a, axis=None, dtype=None, out=None, min_count=None): 193: def nancumsum(a, axis=None, dtype=None, out=None): 199: def nancumprod(a, axis=None, dtype=None, out=None):

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.clip() no longer supports the out argument 879033384
834591933 https://github.com/pydata/xarray/issues/5278#issuecomment-834591933 https://api.github.com/repos/pydata/xarray/issues/5278 MDEyOklzc3VlQ29tbWVudDgzNDU5MTkzMw== max-sixty 5635139 2021-05-07T16:23:50Z 2021-05-07T16:23:50Z MEMBER

FYI I'm out on paternity leave for a few weeks.

Generally IIRC out hasn't been part of the public API, and only present because of our delegating to numpy for some functions.

What is the case for having out kwargs?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.clip() no longer supports the out argument 879033384

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);