issue_comments

Table actions

7 rows where author_association = "MEMBER" and issue = 877016428 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Numpy string coding · 7 ✖

author_association 1

  • MEMBER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1003213647 https://github.com/pydata/xarray/pull/5264#issuecomment-1003213647 https://api.github.com/repos/pydata/xarray/issues/5264 IC_kwDOAMm_X847y9NP Illviljan 14371165 2021-12-30T23:40:28Z 2021-12-30T23:40:28Z MEMBER

Thanks @znicholls!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Numpy string coding 877016428
966623422 https://github.com/pydata/xarray/pull/5264#issuecomment-966623422 https://api.github.com/repos/pydata/xarray/issues/5264 IC_kwDOAMm_X845nYC- Illviljan 14371165 2021-11-11T21:03:23Z 2021-11-11T21:03:23Z MEMBER

Looks good to me, nice work!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Numpy string coding 877016428
879529471 https://github.com/pydata/xarray/pull/5264#issuecomment-879529471 https://api.github.com/repos/pydata/xarray/issues/5264 MDEyOklzc3VlQ29tbWVudDg3OTUyOTQ3MQ== shoyer 1217238 2021-07-14T02:08:23Z 2021-07-14T02:08:23Z MEMBER

To add a bit more clarification: the vlen dtype should correspond to an HDF5/netCDF4 compatible data-type, like a variable length string or bytes. np.str_ is just a NumPy variant of str, so the correct dtype is create_vlen_dtype(str).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Numpy string coding 877016428
879528577 https://github.com/pydata/xarray/pull/5264#issuecomment-879528577 https://api.github.com/repos/pydata/xarray/issues/5264 MDEyOklzc3VlQ29tbWVudDg3OTUyODU3Nw== shoyer 1217238 2021-07-14T02:06:26Z 2021-07-14T02:06:26Z MEMBER

My suggestion is that either _infer_dtype (https://github.com/pydata/xarray/blob/f9a535c130615fe81379d785dffcc6c814fc1126/xarray/conventions.py#L160-L161 ) or the underlying create_vlen_dtype should be updated, so it never puts np.str_ inside a custom vlen dtype. Instead, we should normalize element_type to always be str or bytes inside the vlen dtype.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Numpy string coding 877016428
848946770 https://github.com/pydata/xarray/pull/5264#issuecomment-848946770 https://api.github.com/repos/pydata/xarray/issues/5264 MDEyOklzc3VlQ29tbWVudDg0ODk0Njc3MA== shoyer 1217238 2021-05-26T16:58:29Z 2021-05-26T16:58:29Z MEMBER

I think the issue must be somewhere around this line, where xarray attempts to infer a dtype for object arrays: https://github.com/pydata/xarray/blob/f9a535c130615fe81379d785dffcc6c814fc1126/xarray/conventions.py#L215

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Numpy string coding 877016428
848522696 https://github.com/pydata/xarray/pull/5264#issuecomment-848522696 https://api.github.com/repos/pydata/xarray/issues/5264 MDEyOklzc3VlQ29tbWVudDg0ODUyMjY5Ng== shoyer 1217238 2021-05-26T07:05:38Z 2021-05-26T07:05:38Z MEMBER

I agree, this should totally work. It's not obvious to me how to best fix it, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Numpy string coding 877016428
833208350 https://github.com/pydata/xarray/pull/5264#issuecomment-833208350 https://api.github.com/repos/pydata/xarray/issues/5264 MDEyOklzc3VlQ29tbWVudDgzMzIwODM1MA== shoyer 1217238 2021-05-06T04:06:04Z 2021-05-06T04:06:04Z MEMBER

So far I've just added a single test which fails. I don't think the test should fail although I'm not sure what the np.str_ type actually is so maybe this isn't a bug? Help/advice greatly appreciated.

What problem are you trying to solve here?

This vlen string stuff is an internal API that isn't really intended for use outside Xarray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Numpy string coding 877016428

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);