issue_comments

Table actions

7 rows where author_association = "MEMBER" and issue = 873519048 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Add drop_duplicates for dims · 7 ✖

author_association 1

  • MEMBER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
841699781 https://github.com/pydata/xarray/pull/5239#issuecomment-841699781 https://api.github.com/repos/pydata/xarray/issues/5239 MDEyOklzc3VlQ29tbWVudDg0MTY5OTc4MQ== max-sixty 5635139 2021-05-15T17:46:01Z 2021-05-15T17:46:01Z MEMBER

Merging but I or @ahuang11 can do any follow-ups.

Thank you v much @ahuang11 — appreciate this was a lot of work and happy to have you contribute such a good feature.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop_duplicates for dims 873519048
840723034 https://github.com/pydata/xarray/pull/5239#issuecomment-840723034 https://api.github.com/repos/pydata/xarray/issues/5239 MDEyOklzc3VlQ29tbWVudDg0MDcyMzAzNA== dcherian 2448579 2021-05-13T17:47:47Z 2021-05-13T17:47:47Z MEMBER

@shoyer could I confirm that limiting to a single dimension satisfies this? You say "multiple variables" here. I mentioned a single dimension on the call but maybe wasn't clear.

@shoyer can you kindly merge this if you're happy with it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop_duplicates for dims 873519048
839938904 https://github.com/pydata/xarray/pull/5239#issuecomment-839938904 https://api.github.com/repos/pydata/xarray/issues/5239 MDEyOklzc3VlQ29tbWVudDgzOTkzODkwNA== max-sixty 5635139 2021-05-12T16:54:55Z 2021-05-12T16:54:55Z MEMBER

@shoyer could I confirm that limiting to a single dimension satisfies this? You say "multiple variables" here. I mentioned a single dimension on the call but maybe wasn't clear.

If you drop duplicates over multiple variables at once, what dimensions should the result have? In particular -- should it have the original dimensions, or should all dimensions involved be combined into one?

The latter might seem a little crazy now, but would make more sense once we allow dropping over multi-dimensional variables.

If we really want to avoid any possible controversy here, it might be best to stick to only supporting one variable for now, too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop_duplicates for dims 873519048
839925301 https://github.com/pydata/xarray/pull/5239#issuecomment-839925301 https://api.github.com/repos/pydata/xarray/issues/5239 MDEyOklzc3VlQ29tbWVudDgzOTkyNTMwMQ== max-sixty 5635139 2021-05-12T16:33:42Z 2021-05-12T16:33:42Z MEMBER

@ahuang11 we discussed this on the core team call. People are excited to merge this, and appreciate you bearing with the changes.

I suggested that we narrow this even further to one dimension and merge, so we can benefit from this now and consider additions from there. Would that be OK with you?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop_duplicates for dims 873519048
830685610 https://github.com/pydata/xarray/pull/5239#issuecomment-830685610 https://api.github.com/repos/pydata/xarray/issues/5239 MDEyOklzc3VlQ29tbWVudDgzMDY4NTYxMA== keewis 14808389 2021-05-01T19:54:11Z 2021-05-01T19:54:11Z MEMBER

the docs build can probably be fixed by adding newlines before the section headers ("Parameters" / "Returns")

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop_duplicates for dims 873519048
830684407 https://github.com/pydata/xarray/pull/5239#issuecomment-830684407 https://api.github.com/repos/pydata/xarray/issues/5239 MDEyOklzc3VlQ29tbWVudDgzMDY4NDQwNw== max-sixty 5635139 2021-05-01T19:45:12Z 2021-05-01T19:45:12Z MEMBER

If you drop duplicates over multiple variables at once, what dimensions should the result have? In particular -- should it have the original dimensions, or should all dimensions involved be combined into one?

The latter might seem a little crazy now, but would make more sense once we allow dropping over multi-dimensional variables.

If we really want to avoid any possible controversy here, it might be best to stick to only supporting one variable for now, too.

For me this case supports consistent behavior over any number of dims! Which would mean rejecting the "stack only if you supply exactly ndims" proposal.

Completely fine with restricting to one dim for the moment and seeing how that goes (it's always possible to pass .drop_duplicates_coords(dim1).drop_duplicates_coords(dim2).

Were we going with drop_duplicates or drop_duplicates_coords? No strong view from me at all.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop_duplicates for dims 873519048
830683784 https://github.com/pydata/xarray/pull/5239#issuecomment-830683784 https://api.github.com/repos/pydata/xarray/issues/5239 MDEyOklzc3VlQ29tbWVudDgzMDY4Mzc4NA== max-sixty 5635139 2021-05-01T19:39:42Z 2021-05-01T19:39:42Z MEMBER

The docs are failing with:

/home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/5239/xarray/core/dataarray.py:docstring of xarray.core.dataarray.DataArray.drop_duplicates:3: WARNING: Unexpected indentation. /home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/5239/xarray/core/dataarray.py:docstring of xarray.core.dataarray.DataArray.drop_duplicates:4: WARNING: Block quote ends without a blank line; unexpected unindent. looking for now-outdated files... none found

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop_duplicates for dims 873519048

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);