issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 870619014 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • max-sixty · 3 ✖

issue 1

  • Code cleanup · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
840733461 https://github.com/pydata/xarray/pull/5234#issuecomment-840733461 https://api.github.com/repos/pydata/xarray/issues/5234 MDEyOklzc3VlQ29tbWVudDg0MDczMzQ2MQ== max-sixty 5635139 2021-05-13T18:05:12Z 2021-05-13T18:05:12Z MEMBER

Thanks @andersy005 !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Code cleanup 870619014
839875198 https://github.com/pydata/xarray/pull/5234#issuecomment-839875198 https://api.github.com/repos/pydata/xarray/issues/5234 MDEyOklzc3VlQ29tbWVudDgzOTg3NTE5OA== max-sixty 5635139 2021-05-12T15:39:56Z 2021-05-12T15:39:56Z MEMBER

This is going to collect merge conflicts — shall we merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Code cleanup 870619014
831775613 https://github.com/pydata/xarray/pull/5234#issuecomment-831775613 https://api.github.com/repos/pydata/xarray/issues/5234 MDEyOklzc3VlQ29tbWVudDgzMTc3NTYxMw== max-sixty 5635139 2021-05-04T08:37:16Z 2021-05-04T08:37:16Z MEMBER

I feel this PR is too big and diverse to accept it as a whole.

For example I like most changes from older style formatting to f-strings, but I disagree strongly the moving the return statements into functions improves readability.

While I don't have the same sense on the specifics, if people feel strongly then it may be reasonable to revert or pause on some of these.

What do you suggest re the broader PR though? While focused PRs are easier to review and reach agreement — now this is here, it does seem on net beneficial, and we should take advantage of the benefit.

Are there a few items you feel strongly about that we could revert and then merge the rest?

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Code cleanup 870619014

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);