issue_comments

Table actions

15 rows where author_association = "MEMBER", issue = 870292042 and user = 226037 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • alexamici · 15 ✖

issue 1

  • release v0.18.0 · 15 ✖

author_association 1

  • MEMBER · 15 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
833792726 https://github.com/pydata/xarray/issues/5232#issuecomment-833792726 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc5MjcyNg== alexamici 226037 2021-05-06T19:14:44Z 2021-05-06T19:14:44Z MEMBER

@TomNicholas feel free to close the issue once you are done.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833791756 https://github.com/pydata/xarray/issues/5232#issuecomment-833791756 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc5MTc1Ng== alexamici 226037 2021-05-06T19:13:20Z 2021-05-06T19:13:20Z MEMBER

12899 passed, 1145 skipped, 211 xfailed, 63 xpassed, 321 warnings on my Mac.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833781911 https://github.com/pydata/xarray/issues/5232#issuecomment-833781911 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc4MTkxMQ== alexamici 226037 2021-05-06T18:58:28Z 2021-05-06T18:58:28Z MEMBER

How many xarray devs does it take to do a release? Answer: at least 5 apparently

🤦

But next time it will be sooooooo smooth!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833779947 https://github.com/pydata/xarray/issues/5232#issuecomment-833779947 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc3OTk0Nw== alexamici 226037 2021-05-06T18:55:33Z 2021-05-06T18:55:33Z MEMBER

I'm testing after pip install -U xarray just to be on the safe side 😄 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833773183 https://github.com/pydata/xarray/issues/5232#issuecomment-833773183 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc3MzE4Mw== alexamici 226037 2021-05-06T18:49:12Z 2021-05-06T18:49:12Z MEMBER

hmm should I also delete the tag? It appears to be also linked to one of @keewis ' PRs (#5272)

yes, sorry: delete release AND tag. Then re-create release.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833765097 https://github.com/pydata/xarray/issues/5232#issuecomment-833765097 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc2NTA5Nw== alexamici 226037 2021-05-06T18:37:18Z 2021-05-06T18:37:18Z MEMBER

Deleting and re-creating the release should work (I've done it on one of my projects)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833751992 https://github.com/pydata/xarray/issues/5232#issuecomment-833751992 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc1MTk5Mg== alexamici 226037 2021-05-06T18:17:47Z 2021-05-06T18:17:47Z MEMBER

I guess I can't do this because I'm no one of the registered package owners on PyPI?

Nope. The maintainers on PyPI are Deepak, Joe, Max and Stephan.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833748655 https://github.com/pydata/xarray/issues/5232#issuecomment-833748655 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzc0ODY1NQ== alexamici 226037 2021-05-06T18:12:40Z 2021-05-06T18:13:23Z MEMBER

@dcherian I'm back. I think the easiest is for you to upload the artefacts using with twine. If you need any help I'm in the zoom room.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833652183 https://github.com/pydata/xarray/issues/5232#issuecomment-833652183 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzY1MjE4Mw== alexamici 226037 2021-05-06T16:15:06Z 2021-05-06T16:15:06Z MEMBER

@dcherian I'm sorry, I have cannot make it by 12:30 EST. I think you and @TomNicholas can go on without me or I will be back later.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833603212 https://github.com/pydata/xarray/issues/5232#issuecomment-833603212 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzYwMzIxMg== alexamici 226037 2021-05-06T15:13:13Z 2021-05-06T16:13:50Z MEMBER

@dcherian 11:30-12:30 EST I'm meeting with Stephan and Joe, I hope to have them merge #5235 :)

~12:30 EST is fine by me.~ I cannot make it :/

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833564314 https://github.com/pydata/xarray/issues/5232#issuecomment-833564314 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzU2NDMxNA== alexamici 226037 2021-05-06T14:22:55Z 2021-05-06T14:25:12Z MEMBER

@TomNicholas I'm in Europe, with a meeting at 17:30-18:30 CEST (11:30-12:30 EST) we can probably start now-ish and finish after 3pm EST. I propose to hijack the community meeting zoom :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
833539672 https://github.com/pydata/xarray/issues/5232#issuecomment-833539672 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMzUzOTY3Mg== alexamici 226037 2021-05-06T13:50:28Z 2021-05-06T13:50:28Z MEMBER

@TomNicholas & @dcherian I'm having a look at the what's new, shall we set a time for going through the release process? do we want do the steps while in a call?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
832448319 https://github.com/pydata/xarray/issues/5232#issuecomment-832448319 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMjQ0ODMxOQ== alexamici 226037 2021-05-05T06:35:02Z 2021-05-05T10:38:35Z MEMBER

Form what I can see the #5258 "bump versions" looks ready, someone with knowledge about minimum versions please merge it.

After that is in, @dcherian you can probably uncomment the var._meta bit in #4740 "faster interp" and we can merge it as well. Again I'm not a user of that part of code, and I would feel more conformable if someone with more knowledge would click on the "merge" button.

This leaves only #5235 as a blocker that has a failing test, a proposed fix by @keewis. ~but the OP hasn't responded yet. How should we handle it?~ This looks ready to merge now. Sorry @tomwhite I read the timestamps wrong. Great job!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
832452876 https://github.com/pydata/xarray/issues/5232#issuecomment-832452876 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgzMjQ1Mjg3Ng== alexamici 226037 2021-05-05T06:44:59Z 2021-05-05T06:46:36Z MEMBER

Any thoughts on merging #5244 and doing the v0.18.0 release via GitHub Actions?

I'm using GA in a couple of repositories and I find them very handy, but I usually had to make a couple of releases before getting all the details right, which looks awkward to do with a high profile project like xarray.

We could try release one or more release candidates and go for v0.18.0 only after we are sure the GA release procedure is working though.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042
829923818 https://github.com/pydata/xarray/issues/5232#issuecomment-829923818 https://api.github.com/repos/pydata/xarray/issues/5232 MDEyOklzc3VlQ29tbWVudDgyOTkyMzgxOA== alexamici 226037 2021-04-30T08:10:37Z 2021-04-30T08:10:51Z MEMBER

I propose the following timeline that is the fastest I can personally try:

  • Monday May the 3rd, feature freeze, please refrain from merging new features unless they are discussed here
  • during feature freeze everybody please help reviewing the PR in the list above
  • Thursday the 6th, target release day, the best would be to schedule a window for a couple of hours (?) for @TomAugspurger and me to going through the release steps together with @dcherian.

@TomAugspurger and others does it work for you all?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release v0.18.0 870292042

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);