issue_comments

Table actions

4 rows where author_association = "MEMBER", issue = 868907284 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 4 ✖

issue 1

  • 'NaT' as fill value and netcdf export · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
828230957 https://github.com/pydata/xarray/issues/5223#issuecomment-828230957 https://api.github.com/repos/pydata/xarray/issues/5223 MDEyOklzc3VlQ29tbWVudDgyODIzMDk1Nw== max-sixty 5635139 2021-04-28T07:47:25Z 2021-04-28T07:47:25Z MEMBER

OK great! Does that mean this is solved? Or you need it on attrs?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   'NaT' as fill value and netcdf export 868907284
828162977 https://github.com/pydata/xarray/issues/5223#issuecomment-828162977 https://api.github.com/repos/pydata/xarray/issues/5223 MDEyOklzc3VlQ29tbWVudDgyODE2Mjk3Nw== max-sixty 5635139 2021-04-28T05:48:25Z 2021-04-28T05:48:25Z MEMBER

Ah so it is a special attrs...

Does putting it on .encoding solve the immediate issue?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   'NaT' as fill value and netcdf export 868907284
828156283 https://github.com/pydata/xarray/issues/5223#issuecomment-828156283 https://api.github.com/repos/pydata/xarray/issues/5223 MDEyOklzc3VlQ29tbWVudDgyODE1NjI4Mw== max-sixty 5635139 2021-04-28T05:32:20Z 2021-04-28T05:32:20Z MEMBER

Please could I ask once more — forgive me if I'm missing something but I did ask this a week ago and still don't understand https://github.com/pydata/xarray/discussions/5200#discussioncomment-638329:

Is there a specific reason _FillValue needs to be in the attrs? (I'm not a big netcdf user so there may be)

Why is xarray not ignoring the _FillValue in attrs?

It's trying to serialize it, as it would any other attrs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   'NaT' as fill value and netcdf export 868907284
827803653 https://github.com/pydata/xarray/issues/5223#issuecomment-827803653 https://api.github.com/repos/pydata/xarray/issues/5223 MDEyOklzc3VlQ29tbWVudDgyNzgwMzY1Mw== max-sixty 5635139 2021-04-27T18:02:38Z 2021-04-27T18:02:38Z MEMBER

Also, it's strange that _FillValue is saved to attrs and not encoding (which means xarray won't actually use it to encode the arrays).

I asked for reference for this in #5200. Agree this is surprising.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   'NaT' as fill value and netcdf export 868907284

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);