issue_comments

Table actions

6 rows where author_association = "MEMBER", issue = 860073545 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • max-sixty · 6 ✖

issue 1

  • Enable __setitem__ for dask versions that support it. · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
830686289 https://github.com/pydata/xarray/pull/5174#issuecomment-830686289 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgzMDY4NjI4OQ== max-sixty 5635139 2021-05-01T19:59:31Z 2021-05-01T19:59:31Z MEMBER

Excellent — thank you @tammasloughran ! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
830433663 https://github.com/pydata/xarray/pull/5174#issuecomment-830433663 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgzMDQzMzY2Mw== max-sixty 5635139 2021-04-30T22:27:23Z 2021-04-30T22:27:23Z MEMBER

@tammasloughran this just needs a whatsnew now!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
830238152 https://github.com/pydata/xarray/pull/5174#issuecomment-830238152 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgzMDIzODE1Mg== max-sixty 5635139 2021-04-30T17:13:07Z 2021-04-30T17:13:07Z MEMBER

@tammasloughran would be great to get this in by https://github.com/pydata/xarray/issues/5232 if you have any time, it's great work. I think it's fairly close to the tests passing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
824241591 https://github.com/pydata/xarray/pull/5174#issuecomment-824241591 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgyNDI0MTU5MQ== max-sixty 5635139 2021-04-21T17:43:51Z 2021-04-21T17:43:51Z MEMBER

After those two suggestions, let's merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
822460282 https://github.com/pydata/xarray/pull/5174#issuecomment-822460282 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgyMjQ2MDI4Mg== max-sixty 5635139 2021-04-19T13:19:05Z 2021-04-19T13:19:05Z MEMBER

I don't quite understand understand what you mean. Like this?

Forgive me not being clear. The current test with the version check is great. And I hadn't realized there was a released dask version — even better that the test is already running on both versions of the code.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
821563673 https://github.com/pydata/xarray/pull/5174#issuecomment-821563673 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgyMTU2MzY3Mw== max-sixty 5635139 2021-04-16T21:04:52Z 2021-04-16T21:04:52Z MEMBER

Looks good! Not sure whether there's a reasonable way of testing this...

Are there any current tests for the error that break on the new version (i.e. because it doesn't raise an error)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);