issue_comments

Table actions

2 rows where author_association = "MEMBER" and issue = 856900805 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Handling of non-string dimension names · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
818809386 https://github.com/pydata/xarray/issues/5148#issuecomment-818809386 https://api.github.com/repos/pydata/xarray/issues/5148 MDEyOklzc3VlQ29tbWVudDgxODgwOTM4Ng== keewis 14808389 2021-04-13T15:05:02Z 2021-04-13T15:05:43Z MEMBER

I guess they could either convert to string or a better error message

I think improving the error message is the way to go.

would you prefer to close this

I think we can keep the discussion here

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handling of non-string dimension names 856900805
818734171 https://github.com/pydata/xarray/issues/5148#issuecomment-818734171 https://api.github.com/repos/pydata/xarray/issues/5148 MDEyOklzc3VlQ29tbWVudDgxODczNDE3MQ== keewis 14808389 2021-04-13T13:25:54Z 2021-04-13T13:29:27Z MEMBER

we do want to allow general hashables to mirror the general dict object (and we do need it for some methods, like to_unstacked_dataset), but this is obviously nothing well tested. The main issue is that right now we sort Dataset dims and would need to be able to convert the keys to something comparable. See also #2173, where I suggested to convert to str. This might be too naive for immutable objects without a custom __str__ / __repr__, so something like this, maybe: python sorted(self.mapping, key=lambda k: (type(k).__qualname__, str(k))) which would group objects with the same type name together

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handling of non-string dimension names 856900805

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);