issue_comments

Table actions

4 rows where author_association = "MEMBER", issue = 823955593 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • dcherian · 4 ✖

issue 1

  • Allow dataset interpolation with different datatypes · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
840639292 https://github.com/pydata/xarray/pull/5008#issuecomment-840639292 https://api.github.com/repos/pydata/xarray/issues/5008 MDEyOklzc3VlQ29tbWVudDg0MDYzOTI5Mg== dcherian 2448579 2021-05-13T15:28:54Z 2021-05-13T15:28:54Z MEMBER

Oops just noticed this is missing a whats-new note. Can you send in a PR with that note please?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow dataset interpolation with different datatypes 823955593
840638811 https://github.com/pydata/xarray/pull/5008#issuecomment-840638811 https://api.github.com/repos/pydata/xarray/issues/5008 MDEyOklzc3VlQ29tbWVudDg0MDYzODgxMQ== dcherian 2448579 2021-05-13T15:28:10Z 2021-05-13T15:28:10Z MEMBER

Thanks @Illviljan ! Great PR. Thank you for your patience

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow dataset interpolation with different datatypes 823955593
796790127 https://github.com/pydata/xarray/pull/5008#issuecomment-796790127 https://api.github.com/repos/pydata/xarray/issues/5008 MDEyOklzc3VlQ29tbWVudDc5Njc5MDEyNw== dcherian 2448579 2021-03-11T14:48:08Z 2021-03-11T14:48:08Z MEMBER

How do you linearly interpolate strings, objects or booleans?

This is why we drop them now. my point is that doing "nearest" when the user has specified method="linear" is v. confusing. Perhaps we should have method="linear+nearest" (or something better) for what you propose: linear for numeric, nearest for everything else.

Q: Does the current version of xarray just ignore strings, objects & booleans when method="nearest"?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow dataset interpolation with different datatypes 823955593
794454523 https://github.com/pydata/xarray/pull/5008#issuecomment-794454523 https://api.github.com/repos/pydata/xarray/issues/5008 MDEyOklzc3VlQ29tbWVudDc5NDQ1NDUyMw== dcherian 2448579 2021-03-09T21:06:38Z 2021-03-09T21:06:38Z MEMBER

This seems like a good change but shouldn't we do this only when method="nearest"?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow dataset interpolation with different datatypes 823955593

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);