issue_comments

Table actions

6 rows where author_association = "MEMBER" and issue = 818583834 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • implemented pad with new-indexes · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1049447285 https://github.com/pydata/xarray/pull/4974#issuecomment-1049447285 https://api.github.com/repos/pydata/xarray/issues/4974 IC_kwDOAMm_X84-jUt1 fujiisoup 6815844 2022-02-24T03:02:43Z 2022-02-24T03:02:43Z MEMBER

Hi. Sorry for my late reply. Well, I've just left this PR untouched.

More specifically, the approach here (i.e., passing indexes via the pad_width argument) may be tricky in the context of flexible indexes where multiple indexes/coordinates are allowed for one dimension.

I think we can just discard this PR if this does not fit with the index refactoring. This PR is not big anyway and maybe rewriting this functionality is faster.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implemented pad with new-indexes 818583834
1047997999 https://github.com/pydata/xarray/pull/4974#issuecomment-1047997999 https://api.github.com/repos/pydata/xarray/issues/4974 IC_kwDOAMm_X84-dy4v benbovy 4160723 2022-02-22T16:47:01Z 2022-02-22T16:47:01Z MEMBER

I was wondering what is the status of this PR?

@fujiisoup do you still plan to work on it? Or maybe is it wise to wait for the indexes refactoring (#5692), i.e., https://github.com/pydata/xarray/issues/3868#issuecomment-1047947800 and revisit a bit the approach?

More specifically, the approach here (i.e., passing indexes via the pad_width argument) may be tricky in the context of flexible indexes where multiple indexes/coordinates are allowed for one dimension.

What about another parameter data_values to explicitly pass values to certain (coordinate) variables? It would accept something like {var_name: (before_values, after_values)} and would be passed to an Index.pad new method (if var_name is a coordinate with an index) or to Variable.pad as a fallback. This would keep pad_width simple. We'd just need to check that the arrays passed in data_values have dimensions matching with the dimensions of the corresponding variables and have sizes or shapes matching with the sizes specified in pad_width.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implemented pad with new-indexes 818583834
790021474 https://github.com/pydata/xarray/pull/4974#issuecomment-790021474 https://api.github.com/repos/pydata/xarray/issues/4974 MDEyOklzc3VlQ29tbWVudDc5MDAyMTQ3NA== fujiisoup 6815844 2021-03-03T20:08:18Z 2021-03-03T20:08:18Z MEMBER

Thank you @mathause for your suggestion. This looks all the tests are passing now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implemented pad with new-indexes 818583834
789576848 https://github.com/pydata/xarray/pull/4974#issuecomment-789576848 https://api.github.com/repos/pydata/xarray/issues/4974 MDEyOklzc3VlQ29tbWVudDc4OTU3Njg0OA== mathause 10194086 2021-03-03T09:36:22Z 2021-03-03T09:36:22Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implemented pad with new-indexes 818583834
789511208 https://github.com/pydata/xarray/pull/4974#issuecomment-789511208 https://api.github.com/repos/pydata/xarray/issues/4974 MDEyOklzc3VlQ29tbWVudDc4OTUxMTIwOA== fujiisoup 6815844 2021-03-03T07:44:04Z 2021-03-03T07:44:04Z MEMBER

Not sure why the doctest is failing. The same tests in test_dataset.py do not fail...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implemented pad with new-indexes 818583834
788943018 https://github.com/pydata/xarray/pull/4974#issuecomment-788943018 https://api.github.com/repos/pydata/xarray/issues/4974 MDEyOklzc3VlQ29tbWVudDc4ODk0MzAxOA== mathause 10194086 2021-03-02T14:20:59Z 2021-03-02T14:20:59Z MEMBER

I fixed the typo (pad_width_standardized) but I haven't really reviewed the code... There is a doctest that fails - da.pad(dim=1) that should be added as test & fixed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implemented pad with new-indexes 818583834

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);