issue_comments

Table actions

8 rows where author_association = "MEMBER" and issue = 806334969 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • FIX: h5py>=3 string decoding · 8 ✖

author_association 1

  • MEMBER · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
780397774 https://github.com/pydata/xarray/pull/4893#issuecomment-780397774 https://api.github.com/repos/pydata/xarray/issues/4893 MDEyOklzc3VlQ29tbWVudDc4MDM5Nzc3NA== mathause 10194086 2021-02-17T08:41:26Z 2021-02-17T08:41:26Z MEMBER

Thanks a lot @kmuehlbauer!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   FIX: h5py>=3 string decoding 806334969
780049736 https://github.com/pydata/xarray/pull/4893#issuecomment-780049736 https://api.github.com/repos/pydata/xarray/issues/4893 MDEyOklzc3VlQ29tbWVudDc4MDA0OTczNg== kmuehlbauer 5821660 2021-02-16T18:58:34Z 2021-02-16T18:58:34Z MEMBER

Could you suppress the warning in the test suite? https://github.com/pydata/xarray/pull/4893/checks?check_run_id=1885301619#step:11:278

@mathause The FutureWarnings should be silenced by now. I've set decode_vlen_strings=True in all places. So this should also work after deprecated in h5netcdf.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   FIX: h5py>=3 string decoding 806334969
779999705 https://github.com/pydata/xarray/pull/4893#issuecomment-779999705 https://api.github.com/repos/pydata/xarray/issues/4893 MDEyOklzc3VlQ29tbWVudDc3OTk5OTcwNQ== kmuehlbauer 5821660 2021-02-16T17:35:01Z 2021-02-16T17:35:01Z MEMBER

So the plan is to read strings as bytes in the future?

That's what h5py does. h5netcdf just added backwards compatibility using that decode_vlen_strings kwarg. Means downstream users can use decode_vlen_strings=True and have same experience for h5py>=3.0.0 and h5py=2.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   FIX: h5py>=3 string decoding 806334969
779962419 https://github.com/pydata/xarray/pull/4893#issuecomment-779962419 https://api.github.com/repos/pydata/xarray/issues/4893 MDEyOklzc3VlQ29tbWVudDc3OTk2MjQxOQ== mathause 10194086 2021-02-16T16:43:28Z 2021-02-16T16:43:28Z MEMBER

Could you suppress the warning in the test suite? https://github.com/pydata/xarray/pull/4893/checks?check_run_id=1885301619#step:11:278

So the plan is to read strings as bytes in the future?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   FIX: h5py>=3 string decoding 806334969
778029058 https://github.com/pydata/xarray/pull/4893#issuecomment-778029058 https://api.github.com/repos/pydata/xarray/issues/4893 MDEyOklzc3VlQ29tbWVudDc3ODAyOTA1OA== kmuehlbauer 5821660 2021-02-12T07:28:07Z 2021-02-12T07:28:07Z MEMBER

This is good to go from my end. Thanks @shoyer for your help to not get lost in this string encoding/decoding maze.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   FIX: h5py>=3 string decoding 806334969
777795442 https://github.com/pydata/xarray/pull/4893#issuecomment-777795442 https://api.github.com/repos/pydata/xarray/issues/4893 MDEyOklzc3VlQ29tbWVudDc3Nzc5NTQ0Mg== kmuehlbauer 5821660 2021-02-11T21:14:17Z 2021-02-11T21:14:17Z MEMBER

All fixes in place, but we need to wait until h5netcdf=0.10.0 is available on conda-forge. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   FIX: h5py>=3 string decoding 806334969
777729845 https://github.com/pydata/xarray/pull/4893#issuecomment-777729845 https://api.github.com/repos/pydata/xarray/issues/4893 MDEyOklzc3VlQ29tbWVudDc3NzcyOTg0NQ== kmuehlbauer 5821660 2021-02-11T19:23:16Z 2021-02-11T19:23:16Z MEMBER

So it was decided to fix this at h5netcdf. I'll update the PR tomorrow. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   FIX: h5py>=3 string decoding 806334969
777454141 https://github.com/pydata/xarray/pull/4893#issuecomment-777454141 https://api.github.com/repos/pydata/xarray/issues/4893 MDEyOklzc3VlQ29tbWVudDc3NzQ1NDE0MQ== kmuehlbauer 5821660 2021-02-11T13:24:23Z 2021-02-11T13:24:23Z MEMBER

Nice, I didn't expect to get all green at the first hit.

Nevertheless, please have a thorough look at this. I would also like to know how to document this properly in whats-new.txt. Is this a bug fix or internal change or both?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   FIX: h5py>=3 string decoding 806334969

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);