issue_comments

Table actions

7 rows where author_association = "MEMBER" and issue = 742845971 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • Add GH action for running tests against upstream dev · 7 ✖

author_association 1

  • MEMBER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
731697298 https://github.com/pydata/xarray/pull/4583#issuecomment-731697298 https://api.github.com/repos/pydata/xarray/issues/4583 MDEyOklzc3VlQ29tbWVudDczMTY5NzI5OA== jhamman 2443309 2020-11-22T04:37:51Z 2020-11-22T04:37:51Z MEMBER

@andersy005 - done! I manually triggered the CI and it seems to be working now: https://github.com/pydata/xarray/runs/1437420208?check_suite_focus=true

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add GH action for running tests against upstream dev 742845971
731696756 https://github.com/pydata/xarray/pull/4583#issuecomment-731696756 https://api.github.com/repos/pydata/xarray/issues/4583 MDEyOklzc3VlQ29tbWVudDczMTY5Njc1Ng== andersy005 13301940 2020-11-22T04:28:52Z 2020-11-22T04:28:52Z MEMBER

Thank you to everyone who provided feedback/review....

FYI, the GitHub action failed to run after the merge: https://github.com/pydata/xarray/actions/runs/376810413

The logs show this error message:

...and actions/github-script@v3 are not allowed to be used in pydata/xarray. Actions in this workflow must be: within a repository owned by pydata.

It looks like the admins of the "pydata/xarray" repo have set the policy to be “Allow local actions only”. This option only allows the actions defined in the repositories within the same organization “pydata” to be used. Can someone with admin privileges enable the “Allow all actions” option from the repo settings: https://github.com/pydata/xarray/settings/actions?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add GH action for running tests against upstream dev 742845971
731612407 https://github.com/pydata/xarray/pull/4583#issuecomment-731612407 https://api.github.com/repos/pydata/xarray/issues/4583 MDEyOklzc3VlQ29tbWVudDczMTYxMjQwNw== max-sixty 5635139 2020-11-21T17:50:54Z 2020-11-21T17:50:54Z MEMBER

@andersy005 do you want to add to whatsnew?

Either way we can merge later

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add GH action for running tests against upstream dev 742845971
727571379 https://github.com/pydata/xarray/pull/4583#issuecomment-727571379 https://api.github.com/repos/pydata/xarray/issues/4583 MDEyOklzc3VlQ29tbWVudDcyNzU3MTM3OQ== keewis 14808389 2020-11-15T13:39:50Z 2020-11-15T13:40:06Z MEMBER

What should do about the matploblib wheels issue?

since it's broken right now I would keep the version from conda-forge until the nightly wheels are available again

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add GH action for running tests against upstream dev 742845971
727518698 https://github.com/pydata/xarray/pull/4583#issuecomment-727518698 https://api.github.com/repos/pydata/xarray/issues/4583 MDEyOklzc3VlQ29tbWVudDcyNzUxODY5OA== andersy005 13301940 2020-11-15T05:36:00Z 2020-11-15T05:36:00Z MEMBER

Of course, @keewis & @max-sixty!

The latest commits include updates to the issue body and adds a build matrix for Python 3.7+. The issue body will look like:

For reference, this is how we currently install the upstream-dev dependencies:

Thank you for the pointer, @keewis! I added PyPI nightly wheels for scipy, numpy, pandas... What should do about the matploblib wheels issue?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add GH action for running tests against upstream dev 742845971
727093201 https://github.com/pydata/xarray/pull/4583#issuecomment-727093201 https://api.github.com/repos/pydata/xarray/issues/4583 MDEyOklzc3VlQ29tbWVudDcyNzA5MzIwMQ== keewis 14808389 2020-11-14T00:04:56Z 2020-11-14T01:00:44Z MEMBER

thanks, @andersy005, this looks great.

For reference, this is how we currently install the upstream-dev dependencies: https://github.com/pydata/xarray/blob/dd9fe2a8a414ddefa3b04b934163c9ccc628c5c7/ci/azure/install.yml#L13-L53

Installing matplotlib doesn't work right now, though (see #4256).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add GH action for running tests against upstream dev 742845971
727094003 https://github.com/pydata/xarray/pull/4583#issuecomment-727094003 https://api.github.com/repos/pydata/xarray/issues/4583 MDEyOklzc3VlQ29tbWVudDcyNzA5NDAwMw== max-sixty 5635139 2020-11-14T00:08:28Z 2020-11-14T00:08:28Z MEMBER

This is awesome! Thanks for kicking it off @andersy005 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add GH action for running tests against upstream dev 742845971

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);