issue_comments

Table actions

6 rows where author_association = "MEMBER" and issue = 733789095 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Dask friendly check in `.weighted()` · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
724119273 https://github.com/pydata/xarray/pull/4559#issuecomment-724119273 https://api.github.com/repos/pydata/xarray/issues/4559 MDEyOklzc3VlQ29tbWVudDcyNDExOTI3Mw== mathause 10194086 2020-11-09T16:22:51Z 2020-11-09T16:22:51Z MEMBER

Thanks @jbusecke 

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dask friendly check in `.weighted()` 733789095
723170944 https://github.com/pydata/xarray/pull/4559#issuecomment-723170944 https://api.github.com/repos/pydata/xarray/issues/4559 MDEyOklzc3VlQ29tbWVudDcyMzE3MDk0NA== keewis 14808389 2020-11-06T16:25:46Z 2020-11-06T18:44:35Z MEMBER

this CI is sometimes flaky, but it's usually enough to just rerun it. I'll do that for you once the other CI finished.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dask friendly check in `.weighted()` 733789095
721833586 https://github.com/pydata/xarray/pull/4559#issuecomment-721833586 https://api.github.com/repos/pydata/xarray/issues/4559 MDEyOklzc3VlQ29tbWVudDcyMTgzMzU4Ng== keewis 14808389 2020-11-04T16:26:05Z 2020-11-04T16:56:49Z MEMBER

the TestDask.test_save_mfdataset_compute_false_roundtrip failure should be #4539, and the failing upstream-dev CI shouldn't be related, either (my guess is that a dependency – most likely numpy – added a new warning). I'll investigate and open a new issue for that (edit: see #4565).

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dask friendly check in `.weighted()` 733789095
720164541 https://github.com/pydata/xarray/pull/4559#issuecomment-720164541 https://api.github.com/repos/pydata/xarray/issues/4559 MDEyOklzc3VlQ29tbWVudDcyMDE2NDU0MQ== mathause 10194086 2020-11-01T22:53:24Z 2020-11-01T22:53:24Z MEMBER

I think you need to do someting along the lines of:

python if dask_duck_array(weights): import dask.array as dsa dsa.map_blocks(_weight_check, weights.data, dtype=weights.dtype) else: _weight_check()

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dask friendly check in `.weighted()` 733789095
720090586 https://github.com/pydata/xarray/pull/4559#issuecomment-720090586 https://api.github.com/repos/pydata/xarray/issues/4559 MDEyOklzc3VlQ29tbWVudDcyMDA5MDU4Ng== keewis 14808389 2020-11-01T13:42:04Z 2020-11-01T13:42:04Z MEMBER

since the test you added requires dask it definitely should get a @requires_dask.

That won't fix all the failing tests, though: map_blocks is only valid if we operate on dask arrays. I guess you either have to apply the function directly on other arrays, or we have to make DataArray.map_blocks on non-dask arrays call to DataArray.map.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dask friendly check in `.weighted()` 733789095
720022225 https://github.com/pydata/xarray/pull/4559#issuecomment-720022225 https://api.github.com/repos/pydata/xarray/issues/4559 MDEyOklzc3VlQ29tbWVudDcyMDAyMjIyNQ== max-sixty 5635139 2020-11-01T03:46:37Z 2020-11-01T03:46:37Z MEMBER

Yes, @requires_dask on the test

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dask friendly check in `.weighted()` 733789095

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);