issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 724453705 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Improve alignment typehints · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
721970067 https://github.com/pydata/xarray/pull/4522#issuecomment-721970067 https://api.github.com/repos/pydata/xarray/issues/4522 MDEyOklzc3VlQ29tbWVudDcyMTk3MDA2Nw== max-sixty 5635139 2020-11-04T20:54:52Z 2020-11-04T20:54:52Z MEMBER

Perfect! Thank you very much @m1so !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve alignment typehints 724453705
721208474 https://github.com/pydata/xarray/pull/4522#issuecomment-721208474 https://api.github.com/repos/pydata/xarray/issues/4522 MDEyOklzc3VlQ29tbWVudDcyMTIwODQ3NA== max-sixty 5635139 2020-11-03T15:43:25Z 2020-11-03T15:43:25Z MEMBER

Great, that makes sense, thanks.

The name maybe makes it sound like an actual type, but not sure what the conventions are there.

Do you want to add a note in the whatsnew? Then we can merge later.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve alignment typehints 724453705
719102163 https://github.com/pydata/xarray/pull/4522#issuecomment-719102163 https://api.github.com/repos/pydata/xarray/issues/4522 MDEyOklzc3VlQ29tbWVudDcxOTEwMjE2Mw== max-sixty 5635139 2020-10-30T00:39:55Z 2020-10-30T00:39:55Z MEMBER

Hi @m1so — thanks for the PR, and sorry it hasn't been reviewed for a few days.

I've restarted a flaky test.

Is the difference between using the TypeVar vs. DataWithCoords directly, that this specifies the type supplied in the objects argument is the same type in the tuple returned by align? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve alignment typehints 724453705

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);