issue_comments

Table actions

6 rows where author_association = "MEMBER", issue = 715730538 and user = 10194086 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date)

user 1

  • mathause · 6 ✖

issue 1

  • deprecate pynio backend · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1086647600 https://github.com/pydata/xarray/issues/4491#issuecomment-1086647600 https://api.github.com/repos/pydata/xarray/issues/4491 IC_kwDOAMm_X85AxO0w mathause 10194086 2022-04-02T14:02:50Z 2022-04-02T14:02:50Z MEMBER

We can uncomment here:

https://github.com/pydata/xarray/blob/305533d585389f7240ae2383a323337d4761d33a/ci/requirements/environment.yml#L36

which adds it back to the test suite. As the version does not change, the new build should also be picked up from

https://github.com/pydata/xarray/blob/305533d585389f7240ae2383a323337d4761d33a/ci/requirements/py38-min-all-deps.yml#L42

(it's nice to see that the build for pynio is fixed, but the package itself does not seem to be actively maintained).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   deprecate pynio backend 715730538
786655192 https://github.com/pydata/xarray/issues/4491#issuecomment-786655192 https://api.github.com/repos/pydata/xarray/issues/4491 MDEyOklzc3VlQ29tbWVudDc4NjY1NTE5Mg== mathause 10194086 2021-02-26T13:42:33Z 2021-02-26T13:42:33Z MEMBER

That would be nice. I would probably call it "xarray-pynio" (?) and move it to the "xarray-contrib" organisation. However, I think this needs a higher-level decision.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   deprecate pynio backend 715730538
786492109 https://github.com/pydata/xarray/issues/4491#issuecomment-786492109 https://api.github.com/repos/pydata/xarray/issues/4491 MDEyOklzc3VlQ29tbWVudDc4NjQ5MjEwOQ== mathause 10194086 2021-02-26T08:27:50Z 2021-02-26T08:27:50Z MEMBER

We just bumped the the minimum version of python-netCDF4 to 1.5 - we won't be able to bump it to 1.6 because of this. So we'll need to decide what to do with pynio before and properly deprecate it.

Worth noting though, that there is no python-netCDF4 version 1.6 at the moment, so this is not all that urgent. netCDF4 has not released a minor version in a long time (March 2019) (but they have done 12 patch releases).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   deprecate pynio backend 715730538
706737872 https://github.com/pydata/xarray/issues/4491#issuecomment-706737872 https://api.github.com/repos/pydata/xarray/issues/4491 MDEyOklzc3VlQ29tbWVudDcwNjczNzg3Mg== mathause 10194086 2020-10-11T17:22:19Z 2020-10-11T17:22:19Z MEMBER

4492 is merged. I changed the title to reflect that pynio should eventually be moved to an external repo but keep the issue open to have the discussion in place. I hope that this should not be too hard after the backend refactor.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   deprecate pynio backend 715730538
705143832 https://github.com/pydata/xarray/issues/4491#issuecomment-705143832 https://api.github.com/repos/pydata/xarray/issues/4491 MDEyOklzc3VlQ29tbWVudDcwNTE0MzgzMg== mathause 10194086 2020-10-07T19:22:46Z 2020-10-07T19:22:46Z MEMBER

Would it be enough to only test using py36-min-all-deps and add a warning to the docs stating that pynio conflicts with netcdf4>1.5.3, and maybe also that the pynio backend will be deprecated soon? Same for pydap, I guess.

Yes, fine for me - check #4492

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   deprecate pynio backend 715730538
704907241 https://github.com/pydata/xarray/issues/4491#issuecomment-704907241 https://api.github.com/repos/pydata/xarray/issues/4491 MDEyOklzc3VlQ29tbWVudDcwNDkwNzI0MQ== mathause 10194086 2020-10-07T12:39:38Z 2020-10-07T12:39:38Z MEMBER

In py36-min-all-deps.yml we already test the newest version of pynio (1.5.5). My suggestion is therefore:

Keep pynio in - py36-min-all-deps.yml (pinned) - py38-all-but-dask.yml (not pinned to make sure we don't miss anything)

Remove pynio from: - py36.yml - py37.yml - py38.yml

Do you agree?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   deprecate pynio backend 715730538

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);