issue_comments

Table actions

15 rows where author_association = "MEMBER" and issue = 708979702 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

issue 1

  • fix Edit on GitHub · 15 ✖

author_association 1

  • MEMBER · 15 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
703309421 https://github.com/pydata/xarray/pull/4460#issuecomment-703309421 https://api.github.com/repos/pydata/xarray/issues/4460 MDEyOklzc3VlQ29tbWVudDcwMzMwOTQyMQ== max-sixty 5635139 2020-10-04T20:11:49Z 2020-10-04T20:11:49Z MEMBER

Thanks @keewis — it's great this is solved 🙏

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix Edit on GitHub 708979702
703285568 https://github.com/pydata/xarray/pull/4460#issuecomment-703285568 https://api.github.com/repos/pydata/xarray/issues/4460 MDEyOklzc3VlQ29tbWVudDcwMzI4NTU2OA== dcherian 2448579 2020-10-04T17:08:38Z 2020-10-04T17:08:38Z MEMBER

Thanks @keewis.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix Edit on GitHub 708979702
702840857 https://github.com/pydata/xarray/pull/4460#issuecomment-702840857 https://api.github.com/repos/pydata/xarray/issues/4460 MDEyOklzc3VlQ29tbWVudDcwMjg0MDg1Nw== keewis 14808389 2020-10-02T16:48:38Z 2020-10-02T16:48:38Z MEMBER

if I remember the meeting correctly, this should be ready for merging?

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   fix Edit on GitHub 708979702
699838876 https://github.com/pydata/xarray/pull/4460#issuecomment-699838876 https://api.github.com/repos/pydata/xarray/issues/4460 MDEyOklzc3VlQ29tbWVudDY5OTgzODg3Ng== shoyer 1217238 2020-09-28T07:42:43Z 2020-09-28T07:42:43Z MEMBER

Let's keep scanpydoc as a docs only dependency, which I think is the easiest option from a GPL compliance perspective (we don't want to make all of xarray GPL)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix Edit on GitHub 708979702
699481759 https://github.com/pydata/xarray/pull/4460#issuecomment-699481759 https://api.github.com/repos/pydata/xarray/issues/4460 MDEyOklzc3VlQ29tbWVudDY5OTQ4MTc1OQ== keewis 14808389 2020-09-26T11:17:54Z 2020-09-26T11:24:34Z MEMBER

naciscdn.org is up again so the build passes and the Edit on Github links are fixed (for injected methods, the link points to the outermost wrapper).

However, since the version is set to master the line numbers github_url determines might be wrong for other versions. Should we remove those?

Apart from that, this should be ready for review?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix Edit on GitHub 708979702
699083069 https://github.com/pydata/xarray/pull/4460#issuecomment-699083069 https://api.github.com/repos/pydata/xarray/issues/4460 MDEyOklzc3VlQ29tbWVudDY5OTA4MzA2OQ== keewis 14808389 2020-09-25T18:24:29Z 2020-09-25T23:31:54Z MEMBER

not sure, I'm trying that right now

Edit: unfortunately it doesn't (unless I need to configure something?)

Edit: So I guess we have to wait for https://naciscdn.org to respond again?

Edit: see nvkelso/natural-earth-vector#416

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix Edit on GitHub 708979702
699081287 https://github.com/pydata/xarray/pull/4460#issuecomment-699081287 https://api.github.com/repos/pydata/xarray/issues/4460 MDEyOklzc3VlQ29tbWVudDY5OTA4MTI4Nw== dcherian 2448579 2020-09-25T18:20:31Z 2020-09-25T18:20:31Z MEMBER

Does that help on CI?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix Edit on GitHub 708979702
699079588 https://github.com/pydata/xarray/pull/4460#issuecomment-699079588 https://api.github.com/repos/pydata/xarray/issues/4460 MDEyOklzc3VlQ29tbWVudDY5OTA3OTU4OA== keewis 14808389 2020-09-25T18:17:06Z 2020-09-25T18:17:06Z MEMBER

to fix this, should we try to use cartopy_offlinedata?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix Edit on GitHub 708979702
699078467 https://github.com/pydata/xarray/pull/4460#issuecomment-699078467 https://api.github.com/repos/pydata/xarray/issues/4460 MDEyOklzc3VlQ29tbWVudDY5OTA3ODQ2Nw== keewis 14808389 2020-09-25T18:14:58Z 2020-09-25T18:14:58Z MEMBER

yes, it seems https://naciscdn.org is down.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix Edit on GitHub 708979702
699074303 https://github.com/pydata/xarray/pull/4460#issuecomment-699074303 https://api.github.com/repos/pydata/xarray/issues/4460 MDEyOklzc3VlQ29tbWVudDY5OTA3NDMwMw== dcherian 2448579 2020-09-25T18:06:12Z 2020-09-25T18:06:12Z MEMBER

These natural earth URLs time out sometimes.

It's timing out on the browser for me now: https://naciscdn.org/naturalearth/110m/physical/ne_110m_coastline.zip

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix Edit on GitHub 708979702
699073110 https://github.com/pydata/xarray/pull/4460#issuecomment-699073110 https://api.github.com/repos/pydata/xarray/issues/4460 MDEyOklzc3VlQ29tbWVudDY5OTA3MzExMA== keewis 14808389 2020-09-25T18:03:54Z 2020-09-25T18:04:49Z MEMBER

okay, so support enabled the flag, but RTD times out while downloading something in plotting.rst (and not just for this branch). Does anyone know what's going on?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix Edit on GitHub 708979702
699047605 https://github.com/pydata/xarray/pull/4460#issuecomment-699047605 https://api.github.com/repos/pydata/xarray/issues/4460 MDEyOklzc3VlQ29tbWVudDY5OTA0NzYwNQ== keewis 14808389 2020-09-25T17:11:35Z 2020-09-25T17:11:35Z MEMBER

I looked at the source of scanpydoc.rtd_github_links. It seems to be a bit larger than I expected, and is also licensed as GPLv3, so I guess it should be fine to keep it as a docs-only dependency (is vendoring GPLv3-licensed code even possible for non-GPL projects?).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix Edit on GitHub 708979702
699021207 https://github.com/pydata/xarray/pull/4460#issuecomment-699021207 https://api.github.com/repos/pydata/xarray/issues/4460 MDEyOklzc3VlQ29tbWVudDY5OTAyMTIwNw== keewis 14808389 2020-09-25T16:17:44Z 2020-09-25T16:17:56Z MEMBER

Shall I email RTD support re DONT_OVERWRITE_SPHINX_CONTEXT or do you want to?

sorry for not telling, I already did that immediately after creating the PR

 
{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 2,
    "eyes": 0
}
   fix Edit on GitHub 708979702
699016123 https://github.com/pydata/xarray/pull/4460#issuecomment-699016123 https://api.github.com/repos/pydata/xarray/issues/4460 MDEyOklzc3VlQ29tbWVudDY5OTAxNjEyMw== max-sixty 5635139 2020-09-25T16:07:44Z 2020-09-25T16:07:44Z MEMBER

Amazing! Thanks @keewis !

Shall I email RTD support re DONT_OVERWRITE_SPHINX_CONTEXT or do you want to?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix Edit on GitHub 708979702
698981855 https://github.com/pydata/xarray/pull/4460#issuecomment-698981855 https://api.github.com/repos/pydata/xarray/issues/4460 MDEyOklzc3VlQ29tbWVudDY5ODk4MTg1NQ== dcherian 2448579 2020-09-25T15:04:04Z 2020-09-25T15:04:04Z MEMBER

vendor github_url because it is only a small part of scanpydoc.

:+1:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix Edit on GitHub 708979702

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);