issue_comments

Table actions

7 rows where author_association = "MEMBER" and issue = 705050342 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Add doctests to release notes · 7 ✖

author_association 1

  • MEMBER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
695838328 https://github.com/pydata/xarray/pull/4440#issuecomment-695838328 https://api.github.com/repos/pydata/xarray/issues/4440 MDEyOklzc3VlQ29tbWVudDY5NTgzODMyOA== keewis 14808389 2020-09-20T21:23:43Z 2020-09-20T21:24:18Z MEMBER

it should, but I'm not sure if we'd have other issues instead. I guess we could try both?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add doctests to release notes 705050342
695836637 https://github.com/pydata/xarray/pull/4440#issuecomment-695836637 https://api.github.com/repos/pydata/xarray/issues/4440 MDEyOklzc3VlQ29tbWVudDY5NTgzNjYzNw== max-sixty 5635139 2020-09-20T21:08:31Z 2020-09-20T21:08:31Z MEMBER

In lieu of fixing https://github.com/pydata/xarray/issues/2821, we could add a step to the release doc to merge stable into master — would that fix the problem?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add doctests to release notes 705050342
695836475 https://github.com/pydata/xarray/pull/4440#issuecomment-695836475 https://api.github.com/repos/pydata/xarray/issues/4440 MDEyOklzc3VlQ29tbWVudDY5NTgzNjQ3NQ== max-sixty 5635139 2020-09-20T21:06:43Z 2020-09-20T21:06:43Z MEMBER

Ah great! I was just trying to figure out why I couldn't find them! Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add doctests to release notes 705050342
695835972 https://github.com/pydata/xarray/pull/4440#issuecomment-695835972 https://api.github.com/repos/pydata/xarray/issues/4440 MDEyOklzc3VlQ29tbWVudDY5NTgzNTk3Mg== keewis 14808389 2020-09-20T21:02:08Z 2020-09-20T21:02:34Z MEMBER

I cherry-picked the commits to master, so only the fix for the Edit on Github and the title line are left

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add doctests to release notes 705050342
695835867 https://github.com/pydata/xarray/pull/4440#issuecomment-695835867 https://api.github.com/repos/pydata/xarray/issues/4440 MDEyOklzc3VlQ29tbWVudDY5NTgzNTg2Nw== max-sixty 5635139 2020-09-20T21:00:53Z 2020-09-20T21:00:53Z MEMBER

Thanks for spotting those @keewis , let me fix

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add doctests to release notes 705050342
695835133 https://github.com/pydata/xarray/pull/4440#issuecomment-695835133 https://api.github.com/repos/pydata/xarray/issues/4440 MDEyOklzc3VlQ29tbWVudDY5NTgzNTEzMw== keewis 14808389 2020-09-20T20:54:05Z 2020-09-20T20:54:44Z MEMBER

Edit: thanks for releasing, @max-sixty!

first of all, current master fails to build on RTD, which is because of a title underline being too short, and a typo in the new dev version section: https://github.com/pydata/xarray/blob/788cd605d8270c6aeb6435eb0760eb5f2d97228a/doc/whats-new.rst#L18-L22

Other than that, I noticed we had a few PRs that merged into stable, which means that these commits were lost during the release. I guess these PRs were opened using RTD's Edit on Github links while viewing the stable docs, so a fix would be related to #2821.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add doctests to release notes 705050342
695793864 https://github.com/pydata/xarray/pull/4440#issuecomment-695793864 https://api.github.com/repos/pydata/xarray/issues/4440 MDEyOklzc3VlQ29tbWVudDY5NTc5Mzg2NA== dcherian 2448579 2020-09-20T14:30:55Z 2020-09-20T14:30:55Z MEMBER

LGTM. thanks Max

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add doctests to release notes 705050342

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);