issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 698577111 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Inconsistency in whether index is created with new dimension coordinate? · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1239064150 https://github.com/pydata/xarray/issues/4417#issuecomment-1239064150 https://api.github.com/repos/pydata/xarray/issues/4417 IC_kwDOAMm_X85J2p5W benbovy 4160723 2022-09-07T08:18:08Z 2022-09-07T08:18:08Z MEMBER

From discussions in #4825 and elsewhere (e.g., https://github.com/pydata/xarray/issues/6607#issuecomment-1126587818), could we say that we're going towards a consensus that the index vs. coordinate API should be decoupled wherever possible?

If that's the case, then set_coords() shouldn't create any index, but it could be chained with set_index() if necessary (or swap_dims() can be used instead).

Apparently set_coords() never created an index? I tested @johnomotani's example back to v0.14. Before v2022.6.0, there was a source of confusion where the Dataset and DataArray reprs still showed an * for the dimension coordinate while it had no index. This is fixed in v2022.6.0 where the reprs are now consistent: no * and no index. Does this solve the issue here?

@johnomotani from your example it looks like the two alternatives below would produce the desired result with v2022.6.0:

  • ds.set_index(x='b')
  • ds.rename(b='x').set_coords('x').set_index(x='x')

I would encourage using the latter. It is more verbose but clearer (each method is explicit).

Note also that Xarray now also supports non-dimension coordinates with an index. Once #6971 is merged, renaming "b" to "x" won't be needed. Instead you'll be able to do something like:

ds = xr.Dataset() ds['a'] = ('x', np.linspace(0,1)) ds['b'] = ('x', np.linspace(3,4)) ds = ds.set_coords('b').set_xindex('b') ds.sel(b=...)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Inconsistency in whether index is created with new dimension coordinate? 698577111
691099568 https://github.com/pydata/xarray/issues/4417#issuecomment-691099568 https://api.github.com/repos/pydata/xarray/issues/4417 MDEyOklzc3VlQ29tbWVudDY5MTA5OTU2OA== dcherian 2448579 2020-09-11T13:36:34Z 2020-09-11T13:36:34Z MEMBER

I think I was trying to fix this in #4108

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Inconsistency in whether index is created with new dimension coordinate? 698577111
690815529 https://github.com/pydata/xarray/issues/4417#issuecomment-690815529 https://api.github.com/repos/pydata/xarray/issues/4417 MDEyOklzc3VlQ29tbWVudDY5MDgxNTUyOQ== max-sixty 5635139 2020-09-11T01:17:42Z 2020-09-11T01:17:42Z MEMBER

Thanks for the clear example @johnomotani !

IIRC, the second creates an index because ds['x'] = ('x', np.linspace(3,4)) is setting a 1D variable where the name of the variable matches the name of its dimension.

I can see why this is a bit confusing, though it's not an unreasonable default imo. There have been some discussions on this on the issue tracker.

Does ds.set_index(x='b') align the examples? Or do you think there's still some confusion from the API?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Inconsistency in whether index is created with new dimension coordinate? 698577111

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);