issue_comments

Table actions

6 rows where author_association = "MEMBER", issue = 694386155 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • max-sixty · 6 ✖

issue 1

  • Fix doctests · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
691319381 https://github.com/pydata/xarray/pull/4408#issuecomment-691319381 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MTMxOTM4MQ== max-sixty 5635139 2020-09-11T21:27:06Z 2020-09-11T21:27:06Z MEMBER

For sure re CI!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
691216926 https://github.com/pydata/xarray/pull/4408#issuecomment-691216926 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MTIxNjkyNg== max-sixty 5635139 2020-09-11T17:19:09Z 2020-09-11T17:19:09Z MEMBER

Thanks a lot @keewis ! This is a big step forward!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
690832039 https://github.com/pydata/xarray/pull/4408#issuecomment-690832039 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MDgzMjAzOQ== max-sixty 5635139 2020-09-11T02:16:08Z 2020-09-11T02:16:08Z MEMBER

Great! To the extent the RTD build failure is not from this branch, shall we merge this now?

(i.e. feel free to merge!)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
690812432 https://github.com/pydata/xarray/pull/4408#issuecomment-690812432 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MDgxMjQzMg== max-sixty 5635139 2020-09-11T01:07:50Z 2020-09-11T01:07:50Z MEMBER

Great! To the extent the RTD build failure is not from this branch, shall we merge this now?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
690710321 https://github.com/pydata/xarray/pull/4408#issuecomment-690710321 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MDcxMDMyMQ== max-sixty 5635139 2020-09-10T20:31:40Z 2020-09-10T20:31:40Z MEMBER

Looks great! I raised an eyebrow about the os.remove but it's limited to a finite set of paths.

Re the warning, we could add an ignore in the doctest prelude?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
687930457 https://github.com/pydata/xarray/pull/4408#issuecomment-687930457 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY4NzkzMDQ1Nw== max-sixty 5635139 2020-09-06T23:17:37Z 2020-09-06T23:17:37Z MEMBER

that was a entirely manual process. However, it should be possible to write a script using doctest.DoctestParser, doctest.DoctestFinder and doctest.DoctestRunner (and I would be surprised if there's nothing like that already).

Well, thanks for doing all that!

On the tool, I agree that would be great. Here's something I did in a day that aimed to do it for any value rather than doctests. Would be easier and less complicated for doctests: https://github.com/max-sixty/pytest-accept

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);