issue_comments

Table actions

2 rows where author_association = "MEMBER" and issue = 688501399 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Zarr store array dtype incorrect · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
822901063 https://github.com/pydata/xarray/issues/4386#issuecomment-822901063 https://api.github.com/repos/pydata/xarray/issues/4386 MDEyOklzc3VlQ29tbWVudDgyMjkwMTA2Mw== shoyer 1217238 2021-04-20T01:23:45Z 2021-04-20T01:23:45Z MEMBER
  • since zarr doesn't have a problem with serializing booleans, should we special-case zarr and other backends with native support for booleans instead of casting to int8?

+1, we shouldn't be converting Zarr data into int8.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr store array dtype incorrect 688501399
808831290 https://github.com/pydata/xarray/issues/4386#issuecomment-808831290 https://api.github.com/repos/pydata/xarray/issues/4386 MDEyOklzc3VlQ29tbWVudDgwODgzMTI5MA== andersy005 13301940 2021-03-28T01:58:27Z 2021-03-28T02:00:31Z MEMBER

I think the culprit here is

https://github.com/pydata/xarray/blob/2bbac154ddacd6d6ec989b040130cd9afb8dc0a1/xarray/conventions.py#L136-L147

As I understand it,

  • This approach was adopted in https://github.com/pydata/xarray/pull/849 to circumvent https://github.com/Unidata/netcdf-c/issues/267.

  • The round-tripping fails due to xr.open_zarr('/tmp/ds1.zarr') resulting in a dataset with 'x' variable with an encoding that has a 'dtype': dtype('int8') entry.

  • since zarr doesn't have a problem with serializing booleans, should we special-case zarr and other backends with native support for booleans instead of casting to int8? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr store array dtype incorrect 688501399

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);