issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 684930038 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • dcherian · 3 ✖

issue 1

  • Set `allow_rechunk=True` in `apply_ufunc` · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
682756591 https://github.com/pydata/xarray/issues/4372#issuecomment-682756591 https://api.github.com/repos/pydata/xarray/issues/4372 MDEyOklzc3VlQ29tbWVudDY4Mjc1NjU5MQ== dcherian 2448579 2020-08-28T15:52:03Z 2020-08-28T15:52:03Z MEMBER

So to maintain backward compatibility, we should add that same check python # core dimensions cannot span multiple chunks for axis, dim in enumerate(core_dims, start=-len(core_dims)): if len(data.chunks[axis]) != 1: raise ValueError( "dimension {!r} on {}th function argument to " "apply_ufunc with dask='parallelized' consists of " "multiple chunks, but is also a core dimension. To " "fix, rechunk into a single dask array chunk along " "this dimension, i.e., ``.chunk({})``, but beware " "that this may significantly increase memory usage.".format( dim, n, {dim: -1} ) )

and set allow_rechunk=True.

We could deprecate and remove this check in a couple of versions but I don't know if it's worth the effort...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set `allow_rechunk=True` in `apply_ufunc` 684930038
680940858 https://github.com/pydata/xarray/issues/4372#issuecomment-680940858 https://api.github.com/repos/pydata/xarray/issues/4372 MDEyOklzc3VlQ29tbWVudDY4MDk0MDg1OA== dcherian 2448579 2020-08-26T15:10:05Z 2020-08-26T15:10:05Z MEMBER

Copying over that comment...

I am pretty confident that existing behavior of xarray.apply_ufunc with un-equal chunks along non-core dimensions is entirely broken. I am OK with just erroring for now.

@shoyer could you please clarify what you meant?

For example, this works with v0.16.0 but fails on master ``` python import operator

import numpy as np

import xarray as xr

a = xr.DataArray(np.ones((10, 10)), dims=("a", "b")).chunk({"a": 2, "b": 1}) b = xr.DataArray(np.ones((10, 10)), dims=("a", "b")).chunk({"a": -1, "b": 4})

xr.apply_ufunc( operator.add, a, b, dask="parallelized", output_dtypes=[a.dtype], ).compute().equals(a.compute() + b.compute()) ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set `allow_rechunk=True` in `apply_ufunc` 684930038
679337446 https://github.com/pydata/xarray/issues/4372#issuecomment-679337446 https://api.github.com/repos/pydata/xarray/issues/4372 MDEyOklzc3VlQ29tbWVudDY3OTMzNzQ0Ng== dcherian 2448579 2020-08-24T20:03:42Z 2020-08-24T20:03:42Z MEMBER

(this is causing downstream test failures: https://github.com/NCAR/pop-tools/pull/59; thanks @mnlevy1981)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set `allow_rechunk=True` in `apply_ufunc` 684930038

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);