issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 659142789 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Allow passing args to preprocess function in open_mfdataset · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
661852012 https://github.com/pydata/xarray/issues/4236#issuecomment-661852012 https://api.github.com/repos/pydata/xarray/issues/4236 MDEyOklzc3VlQ29tbWVudDY2MTg1MjAxMg== TomNicholas 35968931 2020-07-21T13:11:00Z 2020-07-21T13:11:00Z MEMBER

I think the actual solution to my problem is to forget about preprocessing.

I'm glad you've found an alternative way to solve your problem!

Still, it's a side-step around the arg passing issue.

So, please tell me if you disagree, but I see it like this: the only time that you would need to be able to pass arguments in to preprocess is if you need to perform an operation within preprocess (i.e. not simply before or after open_mfdataset) that requires a different argument for each file, but when that argument cannot be derived from each file individually.

If you need to pass in global arguments to preprocess, you can use functools.partial to define the preprocess function as having those arguments already set, and if you need only knowledge about the file being currently opened, then that's the use case preprocess is intended for. I can see that there might be other cases where you can't do either of the above, but how often do they actually occur?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing args to preprocess function in open_mfdataset 659142789
660181397 https://github.com/pydata/xarray/issues/4236#issuecomment-660181397 https://api.github.com/repos/pydata/xarray/issues/4236 MDEyOklzc3VlQ29tbWVudDY2MDE4MTM5Nw== dcherian 2448579 2020-07-17T15:47:46Z 2020-07-17T15:47:46Z MEMBER

'm using other functions like dateparse, or timedelta inside the preprocess function to calculate the dayofyear (which itself is derived from a ipywidget).

ds.time.dt.dayofyear should do this for you: https://xarray.pydata.org/en/stable/time-series.html#datetime-components

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing args to preprocess function in open_mfdataset 659142789
660077641 https://github.com/pydata/xarray/issues/4236#issuecomment-660077641 https://api.github.com/repos/pydata/xarray/issues/4236 MDEyOklzc3VlQ29tbWVudDY2MDA3NzY0MQ== TomNicholas 35968931 2020-07-17T12:22:59Z 2020-07-17T12:22:59Z MEMBER

Before I think about this further - could your problem be solved using functools.partial?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing args to preprocess function in open_mfdataset 659142789

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);