issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 618081836 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • dcherian · 2 ✖

issue 1

  • ENH: use `dask.array.apply_gufunc` in `xr.apply_ufunc` · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
631785279 https://github.com/pydata/xarray/pull/4060#issuecomment-631785279 https://api.github.com/repos/pydata/xarray/issues/4060 MDEyOklzc3VlQ29tbWVudDYzMTc4NTI3OQ== dcherian 2448579 2020-05-20T23:11:41Z 2020-05-20T23:11:41Z MEMBER

good point @mathause. Looks like apply_gufunc tries to make blockwise infer meta and then does its own thing when that fails: https://github.com/dask/dask/blob/3b92efff2e779f59e95e05af9b8f371d56227d02/dask/array/gufunc.py#L417-L440 . I don't understand how this can work in all possible cases.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: use `dask.array.apply_gufunc` in `xr.apply_ufunc`  618081836
631706236 https://github.com/pydata/xarray/pull/4060#issuecomment-631706236 https://api.github.com/repos/pydata/xarray/issues/4060 MDEyOklzc3VlQ29tbWVudDYzMTcwNjIzNg== dcherian 2448579 2020-05-20T20:24:32Z 2020-05-20T20:24:32Z MEMBER

If it does, we don't want to set dask='parallelized' but rather let the function handle dask arrays itself.

I think we still need all the current options for the dask kwarg. There can be disastrous consequences so it's good to make users explicitly choose the behaviour they want.

howto properly handle deprecation (eg. meta)

I don't think we should deprecate meta. Not all user functions can deal with zero shaped inputs, so automatically inferring meta need not always work. We've had to add a similar feature for map_blocks (#3575) so I think meta should stay.

keywords of dask.array.apply_gufunc

Shall we add a new dask_gufunc_kwargs and pass that down to appy_gufunc?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: use `dask.array.apply_gufunc` in `xr.apply_ufunc`  618081836

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);