issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 60441490 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • shoyer · 3 ✖

issue 1

  • ds['time.time'] is broken · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
78102026 https://github.com/pydata/xarray/issues/367#issuecomment-78102026 https://api.github.com/repos/pydata/xarray/issues/367 MDEyOklzc3VlQ29tbWVudDc4MTAyMDI2 shoyer 1217238 2015-03-10T17:18:26Z 2015-03-10T17:18:26Z MEMBER

@jhamman it was not broken before -- ds['time.time'] returned a variable named 'time.time', which does not conflict with 'time'.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds['time.time'] is broken 60441490
78100131 https://github.com/pydata/xarray/issues/367#issuecomment-78100131 https://api.github.com/repos/pydata/xarray/issues/367 MDEyOklzc3VlQ29tbWVudDc4MTAwMTMx shoyer 1217238 2015-03-10T17:09:16Z 2015-03-10T17:09:16Z MEMBER

To clarify: the issue here is that time.time involves the name "time" twice. If the data array is not called "time", then this works properly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds['time.time'] is broken 60441490
78004357 https://github.com/pydata/xarray/issues/367#issuecomment-78004357 https://api.github.com/repos/pydata/xarray/issues/367 MDEyOklzc3VlQ29tbWVudDc4MDA0MzU3 shoyer 1217238 2015-03-10T06:54:34Z 2015-03-10T06:54:34Z MEMBER

We could hack around this, but ultimately this is an implication of a design choice I made for the internals of xray.DataArray, which stores its data in an internal xray.Dataset object, using self.name as the key for the variable with the array's data. This means it is currently impossible to have a DataArray with the same name as on of its coordinates but different values.

The real solution here is to do some internal refactoring to make this possible. My current thinking is to add a constant THIS_ARRAY = object() in xray.core.dataarray, and then use THIS_ARRAY instead of self.name in all internal methods that mess with the private dataset that stores the data on DataArray objects.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds['time.time'] is broken 60441490

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);