issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 600641276 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • keewis · 3 ✖

issue 1

  • pint support for Dataset · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
645572181 https://github.com/pydata/xarray/pull/3975#issuecomment-645572181 https://api.github.com/repos/pydata/xarray/issues/3975 MDEyOklzc3VlQ29tbWVudDY0NTU3MjE4MQ== keewis 14808389 2020-06-17T19:20:02Z 2020-06-17T19:58:50Z MEMBER

yeah, I don't know how to only filter for pint warnings, I tried pytest.mark.filterwarnings("error:::pint[.*]") but that doesn't work

Edit: pytest.mark.filterwarnings("error::pint.UnitStrippedWarning") works so I'm merging.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pint support for Dataset 600641276
645533305 https://github.com/pydata/xarray/pull/3975#issuecomment-645533305 https://api.github.com/repos/pydata/xarray/issues/3975 MDEyOklzc3VlQ29tbWVudDY0NTUzMzMwNQ== keewis 14808389 2020-06-17T18:05:20Z 2020-06-17T18:20:11Z MEMBER

I just found another issue: pint implements prod (but not yet nanprod) so the prod tests could be un-xfailed. However, we define a custom nanprod function that uses where to replace nan with 1. This won't work on quantities since, unlike nan and 0, a bare 1 cannot be put into quantities with a dimension (i.e. with a unit other than dimensionless).

I don't really understand the purpose of nanprod's min_count parameter (and _maybe_null_out) so I'm not sure how to fix that.

For now, I think we can merge this PR on green and I'll add that issue to the list in #3594.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pint support for Dataset 600641276
634626082 https://github.com/pydata/xarray/pull/3975#issuecomment-634626082 https://api.github.com/repos/pydata/xarray/issues/3975 MDEyOklzc3VlQ29tbWVudDYzNDYyNjA4Mg== keewis 14808389 2020-05-27T12:27:29Z 2020-05-27T15:00:37Z MEMBER

it seems assert_allclose was one of the sources of UnitStrippedWarnings, but since there's a bug in pint's isclose (fixed on master) the tests fail now.

Edit: pint will be released in the next few days, so most of the failing CI should pass after that.

Also, because it casted to numpy, there were a few bugs that were hidden.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pint support for Dataset 600641276

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);