issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 592331420 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • keewis · 2 ✖

issue 1

  • Remove old auto combine · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
608015240 https://github.com/pydata/xarray/pull/3926#issuecomment-608015240 https://api.github.com/repos/pydata/xarray/issues/3926 MDEyOklzc3VlQ29tbWVudDYwODAxNTI0MA== keewis 14808389 2020-04-02T18:02:12Z 2020-04-02T18:02:12Z MEMBER

thanks, @TomNicholas, looks good to me.

I opened #3928 for the upstream-dev failures.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   Remove old auto combine 592331420
608010931 https://github.com/pydata/xarray/pull/3926#issuecomment-608010931 https://api.github.com/repos/pydata/xarray/issues/3926 MDEyOklzc3VlQ29tbWVudDYwODAxMDkzMQ== keewis 14808389 2020-04-02T17:54:09Z 2020-04-02T17:57:28Z MEMBER

The warning messages said "will no longer accept" and "will require" in "version 0.15" - that's probably authoritative enough isn't it?

I'd think so, yes. Rereading what the warnings are intended for, FutureWarning is indeed the same as DeprecationWarning, the only difference is the intended target audience. I seem to have confused FutureWarning with PendingDeprecationWarning.

Then my only issue is with the whats-new.rst entry. I'd explicitly state that auto_combine was removed.

Edit: sorry, you also mentioned that. The way I understood "deprecating" was what you meant with "starting the deprecation cycle", so that's where the confusion came from.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove old auto combine 592331420

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);