issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 592312709 and user = 35968931 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • TomNicholas · 3 ✖

issue 1

  • sel along 1D non-index coordinates · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
926049276 https://github.com/pydata/xarray/pull/3925#issuecomment-926049276 https://api.github.com/repos/pydata/xarray/issues/3925 IC_kwDOAMm_X843MmP8 TomNicholas 35968931 2021-09-23T18:20:50Z 2021-09-23T18:21:12Z MEMBER

FYI I probably am not going to work on this PR again - especially as I remember getting quite confused by the indexing internals, which have now changed. If we can just wait for this feature to be enabled via the indexing refactor then I would rather just do that. Perhaps I should close this?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   sel along 1D non-index coordinates 592312709
608018692 https://github.com/pydata/xarray/pull/3925#issuecomment-608018692 https://api.github.com/repos/pydata/xarray/issues/3925 MDEyOklzc3VlQ29tbWVudDYwODAxODY5Mg== TomNicholas 35968931 2020-04-02T18:08:32Z 2020-04-02T18:08:32Z MEMBER

Gotcha, thanks.

Hmm, this seems like a grey area... I think selecting along 1D non-dimension coords is probably way more common than along 2D coords, but I'm biased.

changing the number of dimensions doesn't change functionality

BTW I can immediately think of at least one other place where this rule is broken (#3774) - where going from 0D coords to 1D coords of length 1 changes whether combine_by_coords will accept them.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   sel along 1D non-index coordinates 592312709
608000289 https://github.com/pydata/xarray/pull/3925#issuecomment-608000289 https://api.github.com/repos/pydata/xarray/issues/3925 MDEyOklzc3VlQ29tbWVudDYwODAwMDI4OQ== TomNicholas 35968931 2020-04-02T17:44:39Z 2020-04-02T17:44:39Z MEMBER

In particular, one maxim we've generally held is that changing the number of dimensions doesn't change functionality.

Sorry, could you explain what you mean here? How would this PR violate that?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   sel along 1D non-index coordinates 592312709

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);